Add unsupported --with-system-leveldb configure flag #5085

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:sys_leveldb changing 1 files +24 −1
  1. luke-jr commented at 1:46 AM on October 14, 2014: member

    This enables downstream/packagers to use mainline code completely unpatched, provided they take the extra care on LevelDB required for consensus.

  2. theuni commented at 3:43 AM on October 14, 2014: member

    I'll leave it up to the others to decide if this is really wanted, but if so, please use the usual macros for checking libs/headers so that cross works as intended. Also, if they're not found when the switch was given, configure should exit with an error.

  3. configure: Add unsupported --with-system-leveldb configure flag 2374aac1aa
  4. luke-jr force-pushed on Oct 14, 2014
  5. luke-jr commented at 4:16 AM on October 14, 2014: member

    @theuni I'm not sure what you're suggesting for cross - the usual macros would detect missing libs, but there's no pkg-config information for LevelDB, so it's just going to set the variables the same way. Shouldn't be any problem with cross-compiling regardless. Anyhow, added that for the errors.

  6. theuni commented at 4:28 AM on October 14, 2014: member

    @luke-jr it checks for the existence and usability of the libs for the current host. If compiling for arm and only an x86 lib is encountered, configure will exit.

  7. TheBlueMatt commented at 4:44 AM on October 14, 2014: member

    I think this is a bad idea. This is the kind of thing dostream packagers will eat up and use very gladly...without reading "DANGEROUS; NOT SUPPORTED" or misinterpreting it to mean something else.

  8. TheBlueMatt commented at 4:44 AM on October 14, 2014: member

    Of course thats not to say they wont do it anyway, but making it easier...?

  9. laanwj commented at 6:46 AM on October 14, 2014: member

    I tend to agree with @TheBlueMatt. I also remember we had this discussion before. Back then we put the bar at "easily patchable". Making it a configure option makes it too easy, so NACK.

    (The reason that we include leveldb is that it gives us control over the (consensus-critical) database, and allows patching problems that affect us before upstream if that is necessary. That hasn't changed since then)

  10. luke-jr closed this on Oct 14, 2014

  11. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me