Headers-first is disconnecting nodes added via config. #5097

1. 
   spinza commented at 12:38 pm on October 17, 2014: none

   Just a note that if your headers first (HF) sync is latched on to a relatively fast node other nodes continue to be disconnected even where other nodes are nodes added via -addnode in the config/start-up.

   I would guess this is not a major issue.

   I saw this when I tested a HF node. Also had two other regular nodes present on the LAN. One slower and one faster. I added via bitcoin-cli addnode onetry the two lan nodes to speed up testing HF. The HF node dropped the connection to the slower LAN node.

   I then added the slower LAN node to the conf file with an addnode directive there. The HF node still dropped the slower lan node. It came back every now and then but would then be dropped soon after returning.

   It would be interesting to see what it did with nodes added via -connect. @sipa asked me to add this issue.

2. laanwj added the label P2P on Oct 17, 2014
3. 
   sipa commented at 5:48 pm on January 23, 2017: member

   @gmaxwell Now that we have separated the addnode connections (#9319), maybe we should also protect those from stalling eviction? Instead we could mark them as inactive for purposes of IBD sync, perhaps.
4. 
   willcl-ark commented at 10:19 am on September 29, 2022: member

   I think this issue can be closed now.

   We do not consider manually-connected nodes for Eviction (only Full Outbound or Block-relay):

   https://github.com/bitcoin/bitcoin/blob/def75f0fb51b2d2d54cd4d772cf54d45b0fa5ae8/src/net_processing.cpp#L4831-L4838

   Nor do we consider them for Discouragement/Disconnection:

   https://github.com/bitcoin/bitcoin/blob/def75f0fb51b2d2d54cd4d772cf54d45b0fa5ae8/src/net_processing.cpp#L4727-L4731

5. 
   MarcoFalke commented at 10:33 am on September 29, 2022: member

   There will be a disconnect if stalling (see #9213) or on timeout (see #12291)

Contributors
spinza sipa willcl-ark MarcoFalke

Labels
P2P