It's useful for much more than wallets.
Rename CWalletInterface to CValidationInterface #5105
pull sipa wants to merge 1 commits into bitcoin:master from sipa:renamehandler changing 5 files +33 −33-
sipa commented at 2:07 AM on October 20, 2014: member
-
luke-jr commented at 2:21 AM on October 20, 2014: member
Can we have default no-op virtuals instead of the pure virtuals? EraseFromWallet doesn't make sense in non-wallet interfaces :)
- sipa force-pushed on Oct 20, 2014
-
-
luke-jr commented at 3:15 AM on October 20, 2014: member
Do you want to rename Register/UnregisterWallet?
-
laanwj commented at 7:54 AM on October 20, 2014: member
Rename is a clear improvement, ACK.
Aside: I've always wondered if the intermediate abstract/virtual class makes sense at all. In principle anything could just subscribe/unsubscribe from the signals they care about, instead of having to inherit a class and add methods with specific names (potentially resulting in collisions).
-
a96d113962
Rename CWalletInterface to CValidationInterface
It's useful for much more than wallets.
- sipa force-pushed on Oct 20, 2014
-
-
TheBlueMatt commented at 7:23 PM on October 20, 2014: member
CValidationInterface sounds like something that is doing validation, maybe CValidationClient or so? or CValidationReceiver? I dunno
-
sipa commented at 8:25 PM on October 20, 2014: member
CValidationClient? CValidationSignals? CValidationNotification? CValidationCallbacks? CValidationListener? CValidationVisitor?
Let the bikeshedding begin.
-
-
-
luke-jr commented at 9:30 AM on October 21, 2014: member
Sure, ACK regardless of what it's called. :)
- laanwj merged this on Oct 21, 2014
- laanwj closed this on Oct 21, 2014
- laanwj referenced this in commit b88cb1a96e on Oct 21, 2014
- MarcoFalke locked this on Sep 8, 2021
