CAutoFile: Explicit Get(), IsNull() and remove unused methods #5108

pull laanwj wants to merge 2 commits into bitcoin:master from laanwj:2014_10_cautofile changing 5 files +31 −24

laanwj commented at 10:57 AM on October 20, 2014: member

Continues #5089 Add IsNull() to class CAutoFile and remove operator ! by @rdponticelli, which was missing a few uses of !. This also removes operator FILE*, in favor of an explicit Get().

Without the "magical" behaviour, this makes CAutoFile more like a standard scoped_ptr<>, except that it wraps a FILE* instead of an object, and that it adds serialize stream functionality.
Add IsNull() to class CAutoFile and remove operator ! fef24cab1a
TheBlueMatt commented at 5:51 PM on October 20, 2014: member

utACK
theuni commented at 4:13 AM on October 21, 2014: member

Ahh, so much better. Thanks for this. It was the operators that made me so nervous last time I poked here. An explicit Get() is much better all around.

utACK.
laanwj force-pushed on Oct 22, 2014
CAutoFile: Explicit Get() and remove unused methods
Also add documentation to some methods.
a873823864
laanwj force-pushed on Oct 22, 2014
laanwj merged this on Oct 22, 2014
laanwj closed this on Oct 22, 2014
laanwj referenced this in commit f984c7d7ad on Oct 22, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors