consensus lib work: split ec openssl wrapper into separate files #5118

1. 
   theuni commented at 8:42 pm on October 22, 2014: member

   This unchains CKey/CPubKey from openssl and will allow us to use EC functionality from script without depending on anything else.

   Upcoming PR’s will take advantage of this, I’ve split it up for the sake of review sanity. I can add those here if it would be preferred though.

2. laanwj added the label Improvement on Oct 24, 2014
3. 
   sipa commented at 5:34 pm on October 24, 2014: member

   utACK; didn’t verify move only
4. 
   laanwj commented at 12:12 pm on October 27, 2014: member

   Verified that a43447c8168a30c78f054878ffdccbe7deff557b is move-only apart from

   • Added method CECKey::SanityCheck (which contains only moved code)
5. theuni force-pushed on Oct 27, 2014
6. 
   theuni commented at 6:35 pm on October 27, 2014: member

   @laanwj updated to use begin_ptr as requested.
7. boost: remove CPubKey dependency from CECKey. Follow-up of e405aa48 bdaec6abd3
8. theuni force-pushed on Oct 27, 2014
9. boost: code movement only: split CECKey into separate files 50f71cd52e
10. 
    TheBlueMatt commented at 0:16 am on October 28, 2014: member

     0-----BEGIN PGP SIGNED MESSAGE-----
     1Hash: SHA1
     2
     3ACK commithash 50f71cd52e1eb35b10564f73a54fe5ea5b245418
     4-----BEGIN PGP SIGNATURE-----
     5Version: GnuPG v2
     6
     7iQIcBAEBAgAGBQJUTuBGAAoJEIm7uGY+LmXO+koQANK9SjJ2eWkVriCvGw68913o
     8Ezb70u3URN2aDWdfcxu8RTypbYXqlo9E2Lyq4LYsiLFZ57M/poOK4Vc0PeTs5YDt
     9cg/1gpSLhVVdK9jyJfBaab/1ncE8nXeBCiZ480naILq0KhaXwPRi+vPCKnFMGid/
    10PRrhfXBgLUnKNRwGStF20NcjElJNJUMDFeObPcJR/HeVGQcYyEeuNwxNUM5zHH+y
    11qB06VHuWE9saELWRO1ffH2svFO/QzdGQAZamBEzQCM5rIdGsChiH/fqeRM5rCJTO
    12rA6Gr4sJ0QftY5J0FEfQB/+Ory/wVmYW2vOgyt4HTGvOGLlaM1jXZr78zMbeRoUr
    13xJBXrxdGNcFYpIgO4HmD2+dLnND7f5kxwe6dBx//8B10iefK64/4zIV1wMibhTHt
    14it3fybk06JTbTL6ct13GvoLOs4q3gKJhAQ1WSC4dCOND5e5+BBjNCs5UDEpoATp/
    15TVa17pRSe8Ws5x9CXdyooWbLlBnwWcenj3WbujjjfPj+0AdOP6iUT973kV1ZsSA0
    16tbmDAt4FQgB4iN28LSqV5MtjoJVXx0au6O98ZquowiNyYeoe80VSs9OzLt6mk/Vk
    17tbUTyfi/KniRN2Qh2isIIf3emOAhscW5PnPYDboBCOC9+lU5+wbmfo6EnPV+SAkz
    18ax1u0qLBRu9fJ+mzJmPQ
    19=xcBz
    20-----END PGP SIGNATURE-----
    

11. 
    sipa commented at 3:46 am on October 28, 2014: member

    ACK, verified that the code in ecwrapper.cpp is moved from key.cpp.
12. sipa merged this on Oct 28, 2014
13. sipa closed this on Oct 28, 2014

    ---

14. sipa referenced this in commit 068b7f8ee2 on Oct 28, 2014
15. MarcoFalke locked this on Sep 8, 2021

Contributors
theuni sipa laanwj TheBlueMatt

Labels
Refactoring