I've been running bitcoin gui with these changes for a few days with no obvious effects and they are very common.
Hardening #513
pull cjdelisle wants to merge 1 commits into bitcoin:master from cjdelisle:feature-hardening changing 2 files +71 −1-
cjdelisle commented at 5:06 AM on September 12, 2011: none
-
SomeoneWeird commented at 7:22 AM on September 12, 2011: none
+1
-
gavinandresen commented at 1:49 PM on September 12, 2011: contributor
Can you rebase into one commit? Otherwise, looks good to me (but I'm no expert on obscure gcc compiler flags).
-
TheBlueMatt commented at 2:43 PM on September 12, 2011: member
ACK (if its in one commit). For reference, Bitcoin releases are already built with -fstack-protector (not -fstack-protector-all, however the difference is negligible), -Wl,-z,relro (though not -Wl,-z,now due to its potential performance hit at initial load, something which is minor compared to existing load times), and -D_FORTIFY_SOURCE=2 simply because those are the default for Ubuntu 10.04.
-
sipa commented at 6:18 PM on September 12, 2011: member
ACK (after rebase)
-
Add some hardening to protect against unknown/future exploits. 3f94dfa25f
-
jgarzik commented at 11:43 PM on September 17, 2011: contributor
ACK
-
gavinandresen commented at 2:20 PM on September 19, 2011: contributor
ACK (thanks for the rebase)
- gavinandresen referenced this in commit 5df25e78db on Sep 26, 2011
- gavinandresen merged this on Sep 26, 2011
- gavinandresen closed this on Sep 26, 2011
- coblee referenced this in commit 8ad7210cfb on Jul 17, 2012
- achow101 referenced this in commit ce963f609c on Jul 14, 2018
- lateminer referenced this in commit 79e7a13b07 on Jan 22, 2019
- sipa referenced this in commit cc05fa919a on Mar 30, 2019
- sipa referenced this in commit 54245985fb on Mar 31, 2019
- LongShao007 referenced this in commit 3d9a3d2063 on Jul 15, 2019
- fjahr referenced this in commit dbc3ddd5e2 on Jul 24, 2019
- kallewoof referenced this in commit 2d465aa9cd on Oct 4, 2019
- lateminer referenced this in commit 72a4369f05 on Jul 17, 2020
- KolbyML referenced this in commit bc86927231 on Sep 4, 2020
- rajarshimaitra referenced this in commit 016cbb71f5 on Aug 5, 2021
- DrahtBot locked this on Sep 8, 2021
Labels