make CMessageHeader a dumb storage class #5151

pull theuni wants to merge 1 commits into bitcoin:master from theuni:reducedeps8 changing 6 files +17 −18
  1. theuni commented at 1:28 AM on October 28, 2014: member

    It shouldn't know or care about bitcoind's chain param selection. MessageStartChars is changed to be passed into CMessageHeader's ctor rather than having it pulled from the current app state.

    This isn't necessary for the current consensus lib work, but PR'ing now anyway since it's pretty straightforward and non-intrusive. Fine to wait until post-0.10 if preferred.

  2. sipa commented at 3:13 AM on October 28, 2014: member

    utACK

  3. TheBlueMatt commented at 9:01 PM on October 28, 2014: member 
    -----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

utACK commithash 829c4362675054c6c7e48a2706a8babf84fdf7cd
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJUUAQGAAoJEIm7uGY+LmXO2lUP/1KTULDTSnsn711Nu/U6ascd
hoeLBZRtxoyGGlgEhVERdk7y/olkf2yOc40zkLJ1yRkzZz0pyYw73XOp9axesrCo
AfzEkpyoekJtT+HP6be/3WERlrin6WIVAJnaNyScj66G+dtnZlrljnpegZPw87P+
5Uy98015esEVAU4mnv0ShX5NASAb+tks6MQlz7pGYM+dNqi6ONrRHPzsIrLry5zE
TVfu0/0uUhO1DEiBnbKP7CklbMshMUkig2RbP16qP2sjDuhDpS9OXi+XWlerrklh
iXxuaym8ws8MOKaAJsv26zw5vIvipl6Q6anT2vwNUaLbWXsK2Lhu1a1NUCXPMoLh
rIzEoqai0dePfTTIfCK2M5l5QCCHs2GIV46EuQMHSl0cJgE6ANT63KX4GrW3yp3r
EgRjfsNEYe3Td+J029lf79DQTBVzOwBED0fAowBEoK3BS38cft0zw8kCR9TNXQPy
YAnEOpYrGxED23oX6u52Ppn3ERsZm8sRUMVMzNq9edCrp26crwsfFZx5u0PyXaZ3
h7/Q7V6qB6wmieV+uY0QbSqUGPf5JHh5Bzg2CriNLruPHVOEsViaPNZqg/DrK/9o
9H4tFMeCkeJWERB7/QPV8zjz18SKGoVLfNVqAuwLaUN/qVa26Qs3E6+yQLdd1yw8
SqhzEvQ14MhezMOxImwr
=RuMZ
-----END PGP SIGNATURE-----
  4. laanwj added the label Improvement on Oct 29, 2014
  5. sipa commented at 1:52 PM on November 4, 2014: member

    Needs rebase.

  6. theuni force-pushed on Nov 4, 2014
  7. theuni force-pushed on Nov 4, 2014
  8. theuni commented at 10:45 PM on November 4, 2014: member

    rebased

  9. jgarzik commented at 10:47 PM on November 4, 2014: contributor

    ut ACK

  10. laanwj commented at 10:41 AM on January 16, 2015: member

    @theuni We can easily go one step further here and explicitly pass the start characters into CNetMessage too: eb9d140c591db29a9f33fc6f130edfe4d5e146c2 . I like it slightly better as it moves the call to chainparams from the header to the net implementation file.

  11. theuni commented at 7:57 PM on February 4, 2015: member

    @laanwj Yes, nice change. I've added that here.

    Edit: Added as a new commit to preserve the previous ACKs. Will squash when you're ready.

  12. laanwj referenced this in commit a1735a3dd1 on Feb 10, 2015
  13. jtimon commented at 8:33 PM on February 20, 2015: contributor

    ut ACK

  14. theuni force-pushed on Feb 25, 2015
  15. make CMessageHeader a dumb storage class
    It shouldn't know or care about bitcoind's chain param selection
    eec37136fd
  16. theuni commented at 9:15 PM on February 26, 2015: member

    This had conflicts, so it's been squashed and rebased.

  17. sipa commented at 11:06 AM on March 1, 2015: member

    re-utACK

  18. jtimon commented at 3:45 PM on March 2, 2015: contributor

    re-utACK

  19. sipa merged this on Mar 7, 2015
  20. sipa closed this on Mar 7, 2015
  21. sipa referenced this in commit 2f10aa0fa1 on Mar 7, 2015
  22. random-zebra referenced this in commit cbd9271afb on Sep 7, 2020
  23. DrahtBot locked this on Sep 8, 2021
Contributors
theunisipaTheBlueMattjgarziklaanwjjtimon
Labels
Refactoring
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-18 15:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me