Don't relay alerts to peers before version negotiation #5169

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2014_10_no_alerts_before_version2 changing 1 files +3 −0
  1. laanwj commented at 3:11 PM on October 29, 2014: member

    Fixes #1436.

    Sending alert messages before the negotiation breaks protocol, causing them to be ignored as well as the sending peer to receive a Misbehaving score. This also erroneously prevents the alert from being sent again after version negotiation as it will be already in CNode::setKnown.

  2. Don't relay alerts to peers before version negotiation
    Fixes #1436
    20a5f610d3
  3. sipa commented at 3:23 PM on October 29, 2014: member

    utACK

  4. TheBlueMatt commented at 8:16 PM on October 29, 2014: member 
    -----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

utACK commithash 20a5f610d344dfc1dc0c6e5e9e4b0211370aa563
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJUUUsUAAoJEIm7uGY+LmXOnZEQAL+9Bi317C3s/AoLqJcDE6VW
mkL5hGwHfjwcXBzalViERSgev2GkTxPnKsecMX0KGB64owMZzVv2bKsxVF1WHlWw
yAbp3slk4mxRcPN1EUO3056zX/WZtw6N9fO2cR+lpEVSl1ycaJ1kmy7u5XGb8Z/0
hYmPvGiMoMWB4aeH+0VPE++LzUG3TCSng3yLmg088IWWuxKf1St37tF4fjFeQeHG
ZNlQwqkWWFnH3p4eLYHntx6UNZMON5j+A9F1C8VX9IHie8loY9Hg4ld/WfeaS0cW
YeFK7TumqVQM+co9Gb/h+VyEklQuMUh3C53PXn/Vv4Ecf7XTWNDOodHyBrv18pSe
3MOjzeEWNLx5fP8GzLdjC8GgqfHJPJ2ZHfQCC+mcNHnBbp+4mLuezumLs3y9jERk
gpLsGFHj/hj/b6omWb2N3kZnPbKxdwYaAYmPu81TmjvUDgLNP1mQ8Np4yWOsfZrW
rLLGuWJb1ym2tTcnZ5Qe5uTSQw4rzJp+8AJrsa8nuOPe6/NA7JH0vpSjUwAzwirM
DXELAngzzIWZjVrURxXSvMdWF9Wgm0nsC9e0+DsGXIraeocVd0uH97CbGXb6/vyQ
oNKsIAt1TrBvKouVHPLSJpKhLTRabLxWHgN/4gbWaPOiXfhssooD0RDO9Z9OftqC
HBFpWhqLnmlTbxPKsODp
=DaUu
-----END PGP SIGNATURE-----
  5. laanwj merged this on Nov 3, 2014
  6. laanwj closed this on Nov 3, 2014
  7. laanwj referenced this in commit 7a9356bf16 on Nov 3, 2014
  8. DrahtBot locked this on Sep 8, 2021
Contributors
laanwjsipaTheBlueMatt
Linked (view graph)
#1436 Alerts may be sent to peers before version negotiation is complete
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me