bitcoingui.cpp tries to connect to non-existent slots when compiled with --disable-wallet #5175

issue Arnavion opened this issue on October 30, 2014

Arnavion commented at 5:04 AM on October 30, 2014: contributor
With bitcoin-qt compiled with --disable-wallet, this gets printed in debug.log on startup:
```
GUI: QObject::connect: No such slot BitcoinGUI::gotoOverviewPage() in qt/bitcoingui.cpp:274
GUI: QObject::connect: No such slot BitcoinGUI::gotoSendCoinsPage() in qt/bitcoingui.cpp:276
GUI: QObject::connect: No such slot BitcoinGUI::gotoReceiveCoinsPage() in qt/bitcoingui.cpp:278
GUI: QObject::connect: No such slot BitcoinGUI::gotoHistoryPage() in qt/bitcoingui.cpp:280
```
Referring to https://github.com/bitcoin/bitcoin/blob/9acbb4180a383ff123e07887a24b439cef846e89/src/qt/bitcoingui.cpp#L274 and onwards.

The corresponding slots in bitcoingui.h are under an #ifdef ENABLE_WALLET so presumably these connections should be too.

And yes those pages indeed don't exist in a GUI compiled without a wallet.

(This doesn't have any negative effect other than the log messages.)
laanwj closed this on Oct 30, 2014
Arnavion commented at 5:36 PM on October 30, 2014: contributor

Confirmed fixed. Thanks.
wtogami referenced this in commit 0f9147c149 on Nov 14, 2014
wtogami referenced this in commit 2b042f778f on Dec 23, 2014
reddink referenced this in commit 361548084b on May 27, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors