[Qt] fix slot connection problems when no wallet is loaded #5176

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:gui_connect changing 2 files +16 −14

Diapolo commented at 6:38 AM on October 30, 2014: none
- guard 4 connect calls by an #ifdef when no wallet is loaded to fix "No such slot" warnings
- also add comments when #ifdef ENABLE_WALLET end
- fixes #5175

[Qt] fix slot connection problems when no wallet is loaded

- guard 4 connect calls by an #ifdef when no wallet is loaded to fix "No
  such slot" warnings
- also add comments when #ifdef ENABLE_WALLET end
- fixes #5175

981f7907c4

in src/qt/bitcoingui.cpp:None in 77d4385a9e outdated

 270 | @@ -271,13 +271,15 @@ void BitcoinGUI::createActions(const NetworkStyle *networkStyle)
 271 |      // These showNormalIfMinimized are needed because Send Coins and Receive Coins
 272 |      // can be triggered from the tray menu, and need to show the GUI to be useful.
 273 |      connect(overviewAction, SIGNAL(triggered()), this, SLOT(showNormalIfMinimized()));

laanwj commented at 7:56 AM on October 30, 2014:

Let's put all this inside the #ifdef ENABLE_WALLET; after all, these actions can't be triggered at all in the Node UI

Diapolo commented at 8:32 AM on October 30, 2014:

Done

laanwj merged this on Oct 30, 2014
laanwj closed this on Oct 30, 2014
laanwj referenced this in commit c1def0df51 on Oct 30, 2014
Diapolo deleted the branch on Oct 30, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

laanwj

Linked (view graph)

#5175 bitcoingui.cpp tries to connect to non-existent slots when compiled with --disable-wallet