bitcoin-tx: Add the "-txid" option and add hex-encoded transaction to JSON #5207

Add option to include computed transaction hash in output when hex-encoding is selected.

The hash gets output already for JSON.

When selected, the hex tx hash will be output on another line so as to not break things that are already scripted to the output of this utility.

Looks good to me. Opinions, @jgarzik ?

No objection to outputting the hash somewhere. The norm is providing the txid and hex-encoded TX in JSON output.

Providing the hash as a key=value line separate from the hex-encoded output is a bit odd.

Thanks for the feedback.

I agree, it's a little awkward. My main reason for the key-value pair was to make sure that users did not think that the hex-encoded hash was part of the hex-encoded transaction. I can bring it all onto one line since it's a new flag that won't break anybody yet.

Three options that come to mind:

1. Like Jeff said: {"txid":"hex tx hash", "tx":"hex tx"}
2. hex tx,hex tx hash
3. tx=hex tx,txid=hex tx hash

Option 1 is clean and makes sense to look at. Option 2 is easier to command line script (e.g.- use "cut" instead of going to python, ruby, etc...). Option 3 is a mix.

I kind of like option 2 for scripting ease, but it's not a strong preference. I'll update to use Jeff's idea (option 1) if I don't get any conflicting feedback within a few hours.

Another option is "-hash" command line option, which only outputs the hash. That turns some operations into a two-step process, but is clean and util-friendly. No 'cut' or 'awk' required.

Good idea Jeff! I've incorporated both of your inputs. Now, there is a "-hash" that outputs only the computed transaction hash. There is also a new "-hexhash" that creates the JSON formatted output containing both the hex-encoded transaction and the hex-encoded transaction id. I like this updated commit much more than my original submission.

For the latter, I would recommend simply modifying the "-json" output to include the txid and hex-encoded tx.

That then mirrors what bitcoind produces in some of its output, such as 'getrawtransaction' when 'verbose' flag is true.

Ah, cool, I wasn't aware of that, even better. I looked at getrawtransaction and this latest commit changes course a bit in order to be consistent with that. Now, there are -txid and -verbose options instead of -hash and -hexhash. The -txid is the case where we only show the hex-encoded transaction id/hash. The -verbose option now simply adds the "hex" member to the JSON output. This also makes the "-verbose" flag available for expansion later.

I think we are pretty close. Consider that bitcoind interprets "verbose" as implying the entire JSON output. i.e. "not verbose" is the hex-encoded binary form.

Therefore, (1) -txid as you have it and (2) added "hex" to JSON output should be sufficient. No need for an additional -verbose.

OK, what I hear you saying is that requesting JSON output is synonymous with requesting verbose output in this context. Sounds fine, commit updated.

Looks good to me. Wait a bit for others' comments (if any), rebase into a single commit, and we're done.

Cool, re-based, should be good to go. Thanks for the help and feedback!

ut ACK -- looks good to me

Anything else I need to do to get this request merged in? Thanks!

@mruddy Nothing on your side, besides waiting. We need another dev to ACK it, as we require multiple reviews before merging non-trivial patches.

ACK

utACK