Adoption of the word blockchain #5242

pull sandakersmann wants to merge 41 commits into bitcoin:master from sandakersmann:master changing 38 files +66 −66
  1. sandakersmann commented at 0:04 am on November 8, 2014: contributor
    Cryptocurrency was added to Oxford Dictionaries Online in May this year. I see no reason why the name of Satoshi’s revolutionary invention should be divided into two words. I propose that we adopt the word blockchain and merge this pull request.
  2. Block chain corrected to blockchain
    Block chain corrected to blockchain
    c7a51e1599
  3. Block chain corrected to blockchain
    Block chain corrected to blockchain
    ff94c3f03c
  4. Block chain corrected to blockchain
    Block chain corrected to blockchain
    c56d1c424f
  5. Block chain corrected to blockchain
    Block chain corrected to blockchain
    1788418531
  6. Block chain corrected to blockchain
    Block chain corrected to blockchain
    bb7c78a780
  7. Block chain corrected to blockchain
    Block chain corrected to blockchain
    6ef3c61739
  8. Block chain corrected to blockchain
    Block chain corrected to blockchain
    5e70f3a360
  9. Block chain corrected to blockchain
    Block chain corrected to blockchain
    82301cc0ee
  10. Block chain corrected to blockchain
    Block chain corrected to blockchain
    19d7d536a4
  11. Block chain corrected to blockchain
    Block chain corrected to blockchain
    4ea1fe472a
  12. Block chain corrected to blockchain
    Block chain corrected to blockchain
    b37a11fbc5
  13. Block chain corrected to blockchain
    Block chain corrected to blockchain
    7d144ab3c1
  14. Block chain corrected to blockchain
    Block chain corrected to blockchain
    6f9f25b34f
  15. Block chain corrected to blockchain
    Block chain corrected to blockchain
    ad6a7bdfad
  16. Block chain corrected to blockchain
    Block chain corrected to blockchain
    e410f482cb
  17. Block chain corrected to blockchain
    Block chain corrected to blockchain
    1453cf1d5e
  18. Block chain corrected to blockchain
    Block chain corrected to blockchain
    a3801d14d7
  19. Block chain corrected to blockchain
    Block chain corrected to blockchain
    af10aa4e70
  20. Block chain corrected to blockchain
    Block chain corrected to blockchain
    17e0b0664c
  21. Block chain corrected to blockchain
    Block chain corrected to blockchain
    5f1c3aab95
  22. Block chain corrected to blockchain
    Block chain corrected to blockchain
    761ccedf47
  23. Block chain corrected to blockchain
    Block chain corrected to blockchain
    ac6e6a2d20
  24. Block chain corrected to blockchain
    Block chain corrected to blockchain
    f5c1f94a7c
  25. Block chain corrected to blockchain
    Block chain corrected to blockchain
    2c6ec1029a
  26. Block chain corrected to blockchain
    Block chain corrected to blockchain
    6407b66d61
  27. Block chain corrected to blockchain
    Block chain corrected to blockchain
    3aac887e70
  28. Block chain corrected to blockchain
    Block chain corrected to blockchain
    12f27662b2
  29. Block chain corrected to blockchain
    Block chain corrected to blockchain
    85ae1879a9
  30. Block chain corrected to blockchain
    Block chain corrected to blockchain
    4438adbad9
  31. Block chain corrected to blockchain
    Block chain corrected to blockchain
    0111edd69a
  32. Block chain corrected to blockchain
    Block chain corrected to blockchain
    128506175e
  33. Block chain corrected to blockchain
    Block chain corrected to blockchain
    08b80a9fc8
  34. Block chain corrected to blockchain
    Block chain corrected to blockchain
    f04b98917b
  35. Block chain corrected to blockchain
    Block chain corrected to blockchain
    13de78b25d
  36. Block chain corrected to blockchain
    Block chain corrected to blockchain
    7e1b1940bd
  37. Block chain corrected to blockchain
    Block chain corrected to blockchain
    acc8d9fdb8
  38. Block chain corrected to blockchain
    Block chain corrected to blockchain
    be2c9ea3b1
  39. Block chain corrected to blockchain
    Block chain corrected to blockchain
    abe5c2f389
  40. Block chain corrected to blockchain
    Block chain corrected to blockchain
    079b71e18d
  41. Block chain corrected to blockchain
    Block chain corrected to blockchain
    493f1d816e
  42. Block chain corrected to blockchain
    Block chain corrected to blockchain
    862bb928cc
  43. sandakersmann commented at 0:05 am on November 8, 2014: contributor
    If this get merged I will make a pull for bitcoin.org as well.
  44. gmaxwell commented at 6:58 pm on November 8, 2014: contributor
    Nak. I’d prefer not to do this.
  45. sandakersmann commented at 7:08 pm on November 8, 2014: contributor
    Ok. Any specific reason why you prefer not to do it?
  46. kanzure commented at 7:12 pm on November 8, 2014: contributor
    Independent of whether or not this pull request is accepted, I would suggest squashing these commits into a single commit only. Normally I am a strong supporter of individual, numerous and atomic commits, but when the commit message between each never differs, there’s really no strong reason to use many individual commits to accomplish what could be done with just one.
  47. gmaxwell commented at 7:21 pm on November 8, 2014: contributor

    Yes, I also agree that it should be squashed… right now it’s hard to review and would harm bisect.. Just didn’t mention it because I don’t think this should go in at all.

    The source code isn’t the right place to advocate a new word. This change doesn’t improve clarity, but it touches a lot of files. Pedantically, I don’t know how much “blockchain” makes much sense as a free standing concept; After all, you could apply some minor serialization and commitment transformations and no longer have a blockchain at all, but still have bitcoin identically functional.

  48. jonasschnelli commented at 7:31 pm on November 8, 2014: contributor

    NACK on source-code, source-docs level. It complicates searches. Does not really improve the bitcoin project.

    I would also say, the “blockchain” (bitcoin) is a “block chain”. Block chain is more a type of trusted storage.

  49. sandakersmann commented at 7:32 pm on November 8, 2014: contributor
    Blockchain is not really a new word. It is used along with block chain and block-chain all over the repo. This is a move to establish a standard.
  50. gmaxwell commented at 7:40 pm on November 8, 2014: contributor
    The code is pretty consistent currently; it’s hyphenated in four places. The Bitcoin core source isn’t the place to establish word standards (esp not by making dozens of commits.)
  51. sandakersmann commented at 7:53 pm on November 8, 2014: contributor
    Ok. I see your point about squashing these commits into one. Just need to do some research on how to do that.
  52. jgarzik commented at 7:59 pm on November 8, 2014: contributor

    This is known colloquially as urinating into the wind.

    The same nerds got twisted about when “e-mail” became “email”.

    “blockchain” is just fine, and appears to be coming into common usage.

  53. gmaxwell commented at 8:11 pm on November 8, 2014: contributor
    I don’t think anyone is complaining about the word, just the changes. :)
  54. sandakersmann commented at 10:53 pm on November 8, 2014: contributor
    Squashing these commits into one in #5248
  55. sandakersmann closed this on Nov 8, 2014

  56. jgarzik commented at 11:31 pm on November 8, 2014: contributor

    For future reference, please do not create a new pull request for the same change. That just makes it more difficult to track previous comments.

    Typically, after squashing, you push the new branch to the github branch associated with the pull request using “git push –force”

    Meta: We should put this in a doc somewhere…

  57. sandakersmann commented at 11:37 pm on November 8, 2014: contributor
    Ok, I will research that. I have just been using Firefox until today. Steep learning curve :)
  58. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-31 06:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me