Adoption of the word blockchain #5242
pull sandakersmann wants to merge 41 commits into bitcoin:master from sandakersmann:master changing 38 files +66 −66-
sandakersmann commented at 0:04 am on November 8, 2014: contributorCryptocurrency was added to Oxford Dictionaries Online in May this year. I see no reason why the name of Satoshi’s revolutionary invention should be divided into two words. I propose that we adopt the word blockchain and merge this pull request.
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
Block chain corrected to blockchain
Block chain corrected to blockchain
-
sandakersmann commented at 0:05 am on November 8, 2014: contributorIf this get merged I will make a pull for bitcoin.org as well.
-
gmaxwell commented at 6:58 pm on November 8, 2014: contributorNak. I’d prefer not to do this.
-
sandakersmann commented at 7:08 pm on November 8, 2014: contributorOk. Any specific reason why you prefer not to do it?
-
kanzure commented at 7:12 pm on November 8, 2014: contributorIndependent of whether or not this pull request is accepted, I would suggest squashing these commits into a single commit only. Normally I am a strong supporter of individual, numerous and atomic commits, but when the commit message between each never differs, there’s really no strong reason to use many individual commits to accomplish what could be done with just one.
-
gmaxwell commented at 7:21 pm on November 8, 2014: contributor
Yes, I also agree that it should be squashed… right now it’s hard to review and would harm bisect.. Just didn’t mention it because I don’t think this should go in at all.
The source code isn’t the right place to advocate a new word. This change doesn’t improve clarity, but it touches a lot of files. Pedantically, I don’t know how much “blockchain” makes much sense as a free standing concept; After all, you could apply some minor serialization and commitment transformations and no longer have a blockchain at all, but still have bitcoin identically functional.
-
jonasschnelli commented at 7:31 pm on November 8, 2014: contributor
NACK on source-code, source-docs level. It complicates searches. Does not really improve the bitcoin project.
I would also say, the “blockchain” (bitcoin) is a “block chain”. Block chain is more a type of trusted storage.
-
sandakersmann commented at 7:32 pm on November 8, 2014: contributorBlockchain is not really a new word. It is used along with block chain and block-chain all over the repo. This is a move to establish a standard.
-
gmaxwell commented at 7:40 pm on November 8, 2014: contributorThe code is pretty consistent currently; it’s hyphenated in four places. The Bitcoin core source isn’t the place to establish word standards (esp not by making dozens of commits.)
-
sandakersmann commented at 7:53 pm on November 8, 2014: contributorOk. I see your point about squashing these commits into one. Just need to do some research on how to do that.
-
jgarzik commented at 7:59 pm on November 8, 2014: contributor
This is known colloquially as urinating into the wind.
The same nerds got twisted about when “e-mail” became “email”.
“blockchain” is just fine, and appears to be coming into common usage.
-
gmaxwell commented at 8:11 pm on November 8, 2014: contributorI don’t think anyone is complaining about the word, just the changes. :)
-
sandakersmann commented at 10:53 pm on November 8, 2014: contributorSquashing these commits into one in #5248
-
sandakersmann closed this on Nov 8, 2014
-
jgarzik commented at 11:31 pm on November 8, 2014: contributor
For future reference, please do not create a new pull request for the same change. That just makes it more difficult to track previous comments.
Typically, after squashing, you push the new branch to the github branch associated with the pull request using “git push –force”
Meta: We should put this in a doc somewhere…
-
sandakersmann commented at 11:37 pm on November 8, 2014: contributorOk, I will research that. I have just been using Firefox until today. Steep learning curve :)
-
MarcoFalke locked this on Sep 8, 2021
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-31 06:12 UTC
More mirrored repositories can be found on mirror.b10c.me