unexpected observation after removal of 3rd-party services for IP detection #5274

Using the Bitcoin Core GUI with #5161 merged shows unexpected behaviour. Using the peers tab in our debug console now lists clear IPv4 addresses for reached "via". When selecting a peer this is displayed below the peers address. I'm rather sure this always listed just the .onion address I supply via -externalip and no IPv4 address. I'm not even sure where they are coming from, are these Tor exit node IPs? They are not my own public addresses and seem to differ from peer to peer.

I'm using Tor as proxy 127.0.0.1:9050 set via the optionsdialog and the following command line for starting: -bind=127.0.0.1 -externalip=XYZ.onion. @gmaxwell Any idea for this?

Nothing surprising there to me, intentional change: Prior to 5161 we did not "pfrom->addrLocal = addrMe" except on inbound peers, e.g. we made no record (in memory) of what address our outbound neighbors thought we were using. As part of 5161 I changed it to also record this information that they were sending to us all along... I did this because we needed the information for advertisements, but it also does make the peer info slightly more informative.

Ok, thanks for explaining @gmaxwell - to me this seems a like feature, not a bug, so I'm closing this.