Parse command line parameters and process -help and -version before handling datadir directory in both bitcoind and bitcoin-cli. The home directory can be readonly, ~/.bitcoin can be a link to nowhere, etc. thus prevent displaying assertion to the user in such cases. This often happens to me, because I do have a full blockchain data on the removable disk. This also prevents the directory creation for new users who are running bitcoind for the first time (which is often considered as a bad practice in such cases). This should fix #4059, #3639. See also #3640.
Process help and version arguments before datadir. #5351
pull paveljanik wants to merge 1 commits into bitcoin:master from paveljanik:helpbeforedatadir changing 2 files +42 −39-
paveljanik commented at 7:48 PM on November 22, 2014: contributor
-
Process help and version arguments before datadir. 3d0a1ce193
-
gmaxwell commented at 9:18 PM on November 22, 2014: contributor
utACK when testing someone should check that it doesn't break -help-debug
-
paveljanik commented at 7:24 AM on November 23, 2014: contributor
It doesn't change the -help-debug behavior: bitcoind -help -help-debug prints more options than bitcoind -help.
-
Diapolo commented at 4:20 PM on November 23, 2014: none
What about the GUI path here?
-
paveljanik commented at 4:26 PM on November 23, 2014: contributor
QT is already handling -help and -version before the datadir - see https://github.com/bitcoin/bitcoin/blob/master/src/qt/bitcoin.cpp#L531
-
gmaxwell commented at 8:04 PM on November 23, 2014: contributor
ACK (actually tested now).
-
luke-jr commented at 8:21 PM on November 23, 2014: member
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 utACK 3d0a1ce193a7f94862027de6df24cad7ce659256 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQQcBAEBCAAGBQJUckHaAAoJEL0ClCQh9Iifancf/3hWTZxAhw6QrS2/XzQT5slO qB/uHu0dtoVD3k0pHFKu88qA9mZDDwLuMCRHc8/fthFV35t1x4+JqMlHHSkZuAXt cIMkyO1gVsSU1PNBLkImj043K4brDyLZd11Qx85uO15ZHZTV7PG39xgXmNMMOp/5 lCWWj4rS9+7MCiOpETXkJsCXFuYuthKLxAMya+RABqOYUTZa99BneefLduHgRx5Z yF61x9y5uCuFax567LO4RYnjC5gB3jDCoU744/gMFtX3zRlLtFSCasOgcg/1EeQB eTWZ/Yme1O+DjcajT5NQSxwvV/MNNbQSqm8x/0V9/74UfOY0iKqBz4vbeHaFQgu+ kzKD88GBHvP/J6/G/hiBrP1ll5tKU8t8OlMAI3r7qo+4K+fkptdAhK8l5auoijRD FTlRtfGnGb2+cKOpSIZik9PE2KIZyMQGnxIbZp6vZYnlRYS3Pdbw2CaRGwF7wYH2 yi+BS/9NtHfjreQtL8tMonez0Ojf3KH9WWjAi48ODP/9LP2vS84ty8Z+ew0x0hsm dU+qcdzHmN4NaqjY1MU2ZBiLERdPp8FwR37WxZ2TjYT3p/pmnWwV2tvsdtdJjui2 E/zThZVjwmGPhIZhJKYMGXttzIPh1gdmSXr0Z0yU/p3y1QlK/bQSG9kMuiwg7Kcw 6zuxQE2cxdldG5NmZT3aYa6dfSnEvG3ii5eGXL4t0+/7wtZVj16ziYuK88nc5w2y eZ7cm6a9/d/fWlr+cwI9fQ6Qv7JI3eERCklc8LIwAt6gCqUSizhwDgNxtuqaC3WH ro1MHglBSQX3p0SvfMBiKo9vT2zwuUWPymyJa2x/yGbrOJFnPvHJWBzRGs/8mlA4 F6FPpyYMCT/Xp/qLxbFtgehgutjvHsjT3SEVmDMB69MJRf01xPXjVHlZSVGe6g7s 4e0l3o+ZlmkIdzT3fuRstd4T7loka9m/BeAK1orYzYRwX8RBsi3Ljd63PbZRe23S nvJzusO0UOXEraaV+ITsFAXxiPxsUs7y8inDOKsnG2v7ASB2IbKKrpA+gTacHOX6 PHxo3G5L68mJRxhQ5TQmmcSibqybiivWjIpCJDKImYej5tTsCzDeJ9cV6N1X4OB+ 8KQ0NfuGN2ocvu++1EchiXnruO7zMSP+jRpTtdO64DupvGsJXXkHqHUkEPZl8Pmn ktHyY+VbDAGfY9qXlxbfbRx1NjeKO4CokyS20X9cvMNweFtpvvCWK07pXibhGG7N 4BxAAHsBZlCEVPZDbRrkWyG2dSVdILZ1BqKytx9ikWf0iBz1B3THW6CIsQSeSeFu FfVikBel56Ggy+aMBrc1Q0V8a0PEElFLkRIFkpG3ZH3/slo5iv+jJVzXtaJu8n0= =Be3q -----END PGP SIGNATURE----- -
jgarzik commented at 2:31 PM on November 24, 2014: contributor
ut ACK
- laanwj merged this on Nov 25, 2014
- laanwj closed this on Nov 25, 2014
- laanwj referenced this in commit ac0b2393a4 on Nov 25, 2014
- paveljanik deleted the branch on Nov 25, 2014
- MarcoFalke locked this on Sep 8, 2021
