Process help and version arguments before datadir. #5351

1. 
   paveljanik commented at 7:48 pm on November 22, 2014: contributor

   Parse command line parameters and process -help and -version before handling datadir directory in both bitcoind and bitcoin-cli. The home directory can be readonly, ~/.bitcoin can be a link to nowhere, etc. thus prevent displaying assertion to the user in such cases. This often happens to me, because I do have a full blockchain data on the removable disk. This also prevents the directory creation for new users who are running bitcoind for the first time (which is often considered as a bad practice in such cases). This should fix #4059, #3639. See also #3640.
2. Process help and version arguments before datadir. 3d0a1ce193
3. 
   gmaxwell commented at 9:18 pm on November 22, 2014: contributor

   utACK when testing someone should check that it doesn’t break -help-debug
4. 
   paveljanik commented at 7:24 am on November 23, 2014: contributor

   It doesn’t change the -help-debug behavior: bitcoind -help -help-debug prints more options than bitcoind -help.
5. 
   Diapolo commented at 4:20 pm on November 23, 2014: none

   What about the GUI path here?
6. 
   paveljanik commented at 4:26 pm on November 23, 2014: contributor

   QT is already handling -help and -version before the datadir - see https://github.com/bitcoin/bitcoin/blob/master/src/qt/bitcoin.cpp#L531
7. 
   gmaxwell commented at 8:04 pm on November 23, 2014: contributor

   ACK (actually tested now).
8. 
   luke-jr commented at 8:21 pm on November 23, 2014: member

    0-----BEGIN PGP SIGNED MESSAGE-----
    1Hash: SHA256
    2
    3utACK 3d0a1ce193a7f94862027de6df24cad7ce659256
    4-----BEGIN PGP SIGNATURE-----
    5Version: GnuPG v2
    6
    7iQQcBAEBCAAGBQJUckHaAAoJEL0ClCQh9Iifancf/3hWTZxAhw6QrS2/XzQT5slO
    8qB/uHu0dtoVD3k0pHFKu88qA9mZDDwLuMCRHc8/fthFV35t1x4+JqMlHHSkZuAXt
    9cIMkyO1gVsSU1PNBLkImj043K4brDyLZd11Qx85uO15ZHZTV7PG39xgXmNMMOp/5
   10lCWWj4rS9+7MCiOpETXkJsCXFuYuthKLxAMya+RABqOYUTZa99BneefLduHgRx5Z
   11yF61x9y5uCuFax567LO4RYnjC5gB3jDCoU744/gMFtX3zRlLtFSCasOgcg/1EeQB
   12eTWZ/Yme1O+DjcajT5NQSxwvV/MNNbQSqm8x/0V9/74UfOY0iKqBz4vbeHaFQgu+
   13kzKD88GBHvP/J6/G/hiBrP1ll5tKU8t8OlMAI3r7qo+4K+fkptdAhK8l5auoijRD
   14FTlRtfGnGb2+cKOpSIZik9PE2KIZyMQGnxIbZp6vZYnlRYS3Pdbw2CaRGwF7wYH2
   15yi+BS/9NtHfjreQtL8tMonez0Ojf3KH9WWjAi48ODP/9LP2vS84ty8Z+ew0x0hsm
   16dU+qcdzHmN4NaqjY1MU2ZBiLERdPp8FwR37WxZ2TjYT3p/pmnWwV2tvsdtdJjui2
   17E/zThZVjwmGPhIZhJKYMGXttzIPh1gdmSXr0Z0yU/p3y1QlK/bQSG9kMuiwg7Kcw
   186zuxQE2cxdldG5NmZT3aYa6dfSnEvG3ii5eGXL4t0+/7wtZVj16ziYuK88nc5w2y
   19eZ7cm6a9/d/fWlr+cwI9fQ6Qv7JI3eERCklc8LIwAt6gCqUSizhwDgNxtuqaC3WH
   20ro1MHglBSQX3p0SvfMBiKo9vT2zwuUWPymyJa2x/yGbrOJFnPvHJWBzRGs/8mlA4
   21F6FPpyYMCT/Xp/qLxbFtgehgutjvHsjT3SEVmDMB69MJRf01xPXjVHlZSVGe6g7s
   224e0l3o+ZlmkIdzT3fuRstd4T7loka9m/BeAK1orYzYRwX8RBsi3Ljd63PbZRe23S
   23nvJzusO0UOXEraaV+ITsFAXxiPxsUs7y8inDOKsnG2v7ASB2IbKKrpA+gTacHOX6
   24PHxo3G5L68mJRxhQ5TQmmcSibqybiivWjIpCJDKImYej5tTsCzDeJ9cV6N1X4OB+
   258KQ0NfuGN2ocvu++1EchiXnruO7zMSP+jRpTtdO64DupvGsJXXkHqHUkEPZl8Pmn
   26ktHyY+VbDAGfY9qXlxbfbRx1NjeKO4CokyS20X9cvMNweFtpvvCWK07pXibhGG7N
   274BxAAHsBZlCEVPZDbRrkWyG2dSVdILZ1BqKytx9ikWf0iBz1B3THW6CIsQSeSeFu
   28FfVikBel56Ggy+aMBrc1Q0V8a0PEElFLkRIFkpG3ZH3/slo5iv+jJVzXtaJu8n0=
   29=Be3q
   30-----END PGP SIGNATURE-----
   

9. 
   jgarzik commented at 2:31 pm on November 24, 2014: contributor

   ut ACK
10. laanwj merged this on Nov 25, 2014
11. laanwj closed this on Nov 25, 2014

    ---

12. laanwj referenced this in commit ac0b2393a4 on Nov 25, 2014
13. paveljanik deleted the branch on Nov 25, 2014
14. MarcoFalke locked this on Sep 8, 2021

Contributors
paveljanik gmaxwell Diapolo luke-jr jgarzik