Proxy support broken when onlynet=tor is set, causing connection leak. #5355

1. 
   gmaxwell commented at 11:35 am on November 23, 2014: contributor

   On git master setting -proxy= on a host which is -onlynet=tor no longer sets the generic proxy for v4/v6 at all.

   As a result getinfo is incorrect, as a cosmetic bug the harm would mostly be causing users an undeserved heart attack… but it’s not entirely undeserved:

   This makes the payment protocol connections leak, since they interograte OptionsModel::getProxySettings() which runs GetProxy(NET_IPV4, curProxy).

   I believe that proxy should set the proxy for all networks, even limited ones. I don’t understand why it ever didn’t thus the issue instead of a patch.

2. gmaxwell added the label Bug on Nov 23, 2014
3. gmaxwell added the label Priority High on Nov 23, 2014
4. gmaxwell added this to the milestone 0.10.0 on Nov 23, 2014
5. 
   Diapolo commented at 4:20 pm on November 23, 2014: none

   Would it be easier to finally review #4871 ;) and base new suggestions there on? I believe the code is more robust (but also doesn’t set the proxy for networks that are limited).

   For the payment request, if there is no proxy set because of the net limiting we are not using any. I’m not sure setting a proxy for networks that are limited is correct.

   Edit: Perhaps we should prefer Tor proxy for payment requests over IPv4 proxy and use IPv4 proxy if Tor proxy is not set!?

6. 
   gmaxwell commented at 7:46 pm on November 23, 2014: contributor

   -proxy= sets a proxy that should be used for everything. Making any direct connections when proxy is set is very wrong.
7. 
   gmaxwell commented at 10:45 pm on November 23, 2014: contributor

   @sipa Can you explain the logic for not setting the proxy on IsLimited networks? I don’t see what useful thing it accomplishes.
8. gmaxwell referenced this in commit cd5164aba2 on Nov 24, 2014
9. gmaxwell added this to the milestone 0.9.4 on Nov 27, 2014
10. gmaxwell removed this from the milestone 0.10.0 on Nov 27, 2014
11. 
    gmaxwell commented at 8:19 am on November 27, 2014: contributor

    okay, fixed in master and the 0.9. branch.
12. gmaxwell closed this on Nov 27, 2014

    ---

13. jameshilliard referenced this in commit dac4e5ee62 on Apr 15, 2015
14. reddink referenced this in commit e03db74292 on May 27, 2020
15. DrahtBot locked this on Sep 8, 2021

Contributors
gmaxwell Diapolo

Labels
Bug