Prioritize and display -testsafemode status in UI #5356

pull dexX7 wants to merge 1 commits into bitcoin:master from dexX7:testsafemode-ui-info changing 1 files +3 −3

dexX7 commented at 12:59 PM on November 23, 2014: contributor

Like in a real world situation, a safe mode test should also be visible in the UI. A test of safe mode is furthermore mostly relevant for developers, so it should not be overwritten by a warning about a pre-release test build.

Prioritize and display -testsafemode status in UI

Like in a real world situation, a safe mode test should also be visible in the
UI. A test of safe mode is furthermore mostly relevant for developers, so it
should not be overwritten by a warning about a pre-release test build.

7357893396

sipa commented at 1:27 PM on November 23, 2014: member

utACK
in src/main.cpp:None in 7357893396
```
3226 | -
3227 |      if (!CLIENT_VERSION_IS_RELEASE)
3228 |          strStatusBar = _("This is a pre-release test build - use at your own risk - do not use for mining or merchant applications");
3229 |  
3230 | +    if (GetBoolArg("-testsafemode", false))
3231 | +        strStatusBar = strRPC = "testsafemode enabled";
```
Diapolo commented at 4:13 PM on November 23, 2014:

If this is visible in the UI it should be translated and use more descriptive message or a sentence IMHO.

dexX7 commented at 4:15 PM on November 23, 2014:

Great idea. Any suggestion for a default?

laanwj commented at 7:30 AM on November 24, 2014:

This is a test option, let's not burden translators with this.

gmaxwell commented at 7:38 AM on November 24, 2014:

I actually think it should not be translated. Translating it will break software which is attempting to use it. This field is not generally for human reading, but e.g. automatic tests of your alterting infrastructure would happily key on the specific text.
gmaxwell commented at 7:58 PM on November 23, 2014: contributor

ACK
laanwj commented at 7:52 AM on November 24, 2014: member

Worksforme. ACK commithash 7357893396eb9ec6aafbce52bede0b7b31a97ddc https://dev.visucore.com/bitcoin/acks/5356
laanwj merged this on Nov 24, 2014
laanwj closed this on Nov 24, 2014
laanwj referenced this in commit c24d07554b on Nov 24, 2014
dexX7 deleted the branch on Nov 24, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors