Make -proxy set all network types, avoiding a connect leak. #5358

1. 
   gmaxwell commented at 11:18 pm on November 23, 2014: contributor

   Previously -proxy was not setting the proxy for IsLimited networks, so if you set your configuration to be onlynet=tor you wouldn’t get an IPv4 proxy set.

   The payment protocol gets its proxy configuration from the IPv4 proxy, and so it would experience a connection leak.

   This addresses issue #5355 and also clears up a cosmetic bug where getinfo proxy output shows nothing when onlynet=tor is set.

2. Make -proxy set all network types, avoiding a connect leak.

   Previously -proxy was not setting the proxy for IsLimited networks, so
    if you set your configuration to be onlynet=tor you wouldn't get an
    IPv4 proxy set.
   
   The payment protocol gets its proxy configuration from the IPv4 proxy,
    and so it would experience a connection leak.
   
   This addresses issue #5355 and also clears up a cosmetic bug where
    getinfo proxy output shows nothing when onlynet=tor is set.

   3c77714134
3. 
   laanwj commented at 7:11 am on November 24, 2014: member

   Ouch ouch ouch. Good catch. Ideally the payment request code wouldn’t even try connecting over IPv4 if the network is limited, but better to err on the safe side. ACK commithash 3c777141349ad82d679a278df0619968af53c23f https://dev.visucore.com/bitcoin/acks/5358
4. laanwj added this to the milestone 0.10.0 on Nov 24, 2014
5. laanwj added the label Priority High on Nov 24, 2014
6. 
   laanwj commented at 7:16 am on November 24, 2014: member

   Needs backport to 0.9.x too.
7. 
   sipa commented at 2:25 pm on November 24, 2014: member

   utACK
8. 
   jgarzik commented at 2:29 pm on November 24, 2014: contributor

   ut ACK
9. laanwj merged this on Nov 24, 2014
10. laanwj closed this on Nov 24, 2014

    ---

11. laanwj referenced this in commit 6f9e67aca7 on Nov 24, 2014
12. gmaxwell referenced this in commit cd5164aba2 on Nov 24, 2014
13. MarcoFalke locked this on Sep 8, 2021

Contributors
gmaxwell laanwj sipa jgarzik

Milestone
0.10.0