libbitcoinconsensus: don't require any global constructors #5361

1. 
   theuni commented at 8:21 PM on November 24, 2014: member

   These static objects are only used in once place, so declare them there instead.

   After these changes, I've verified via clang's -Wglobal-constructors that no global constructors are required.

2. libbitcoinconsensus: don't require any global constructors

   These static objects are only used in once place, so declare them there instead.

   322317951f
3. 
   sipa commented at 8:24 PM on November 24, 2014: member

   utACK

4. 
   luke-jr commented at 9:19 PM on November 24, 2014: member

   utACK

5. 
   gmaxwell commented at 10:39 PM on November 24, 2014: contributor

   ACK

6. 
   laanwj commented at 8:41 AM on November 25, 2014: member

   ACK, but also needs a comment at the top of the file that people should not add global initializers.

7. laanwj added this to the milestone 0.10.0 on Nov 25, 2014
8. 
   laanwj commented at 9:44 AM on November 26, 2014: member

   Discussed with @theuni on IRC, instead of a comment he's going to add a -Werror -Wglobal-constructors to the bitcoinconsensus build to avoid global constructors popping up in the future.

9. laanwj merged this on Nov 26, 2014
10. laanwj closed this on Nov 26, 2014

    ---

11. laanwj referenced this in commit e6751ca68a on Nov 26, 2014
12. MarcoFalke locked this on Sep 8, 2021

Milestone
0.10.0