Digit group separator(s) #5372

issue ghost opened this issue on November 26, 2014
  1. ghost commented at 1:31 AM on November 26, 2014: none

    I suspect that following a purported "SI-style" (only to the left of the decimal point though) in using a thin space as a digit group separator for BTC balances (i.e. Available: 5 350.00000000 BTC) in Bitcoin-Qt may be lost on Joe Sixpack. I wonder whether this needs to be explicitly stated in the UI, or localized. So, submitting the observations despite Qt's slide down the priority list.

    The code also fails to properly implement the suggested objective (bitcoinunits.cpp +109-112) "on both sides of the decimal point" (i.e. "Total: 6 026.00003730 BTC").

  2. laanwj commented at 9:50 AM on November 26, 2014: member

    We're not going back to this discusson. Please read it back in #4167 .

    I even implemented localized number separators at some point. See #3893. No one even tested it AFAIK, just comments about how it could be confusing when misconfigured, and everyone was in favor of using thin spaces.

    Anyhow: Bitcoin Core is not aimed at Joe Sixpack. That segment is covered by a great variety of SPV and mobile wallets.

  3. laanwj closed this on Nov 26, 2014

  4. ghost commented at 1:31 AM on November 27, 2014: none

    @laanwj, what are your thoughts on the bottom paragraph? Should the code or the comment be updated, or do we not care about the mismatch i.e. using the digit group separator only for the quotient?

    The digit group separator is also used regardless of whether there are five or more digits in the Total or Available balances, contrary to the stated intent in the comment.

  5. laanwj commented at 8:36 AM on November 27, 2014: member

    It used to do the separation on both sides of the dot, but that was reverted as we couldn't get used to it. My suggestion would be to change your units to mBTC or muBTC, you'll have the same result without having to learn a new number representation.

  6. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me