Update the intent on SI-style separators. #5388

pull ghost wants to merge 1 commits into bitcoin:master from changing 1 files +2 −4

ghost commented at 5:16 AM on November 28, 2014: none

Clean up of #5372

in src/qt/bitcoinunits.cpp:None in 57343cdc69 outdated

 105 | @@ -106,10 +106,8 @@ QString BitcoinUnits::format(int unit, const CAmount& nIn, bool fPlus, Separator
 106 |      QString quotient_str = QString::number(quotient);
 107 |      QString remainder_str = QString::number(remainder).rightJustified(num_decimals, '0');
 108 |  
 109 | -    // Use SI-stule separators as these are locale indendent and can't be
 110 | -    // confused with the decimal marker.  Rule is to use a thin space every
 111 | -    // three digits on *both* sides of the decimal point - but only if there
 112 | -    // are five or more digits
 113 | +    // Use SI-stule thin space separators as these are locale indendent and can't be

laanwj commented at 8:07 AM on November 28, 2014:

Shouldn't this be SI-style instead of SI-stule?

laanwj added the label Docs and Output on Nov 28, 2014
Update the intent on SI-style separators. 1cf23f6c50
ghost commented at 3:37 PM on November 28, 2014: none

Fixed both typos, "SI-stule" and "indendent".
sipa commented at 4:12 PM on November 28, 2014: member

I'm confused. I thought the small-spaces-separators thing got reverted? (no opinion either way here; just asking what this is about...)
ghost commented at 6:50 PM on November 28, 2014: none

Apparently thin spaces are still alive and kicking, but only to the left of the decimal marker, and regardless of the number of digits involved in the quotient (of course greater than 3 that is, but not 4). So this commit is no more but the code comment catching up with the code. The code rationale itself is covered by Wladimir in #5372.
laanwj commented at 9:17 AM on December 1, 2014: member

Only separators to the right of the decimal point were reverted. IMO as non-physicist it was too hard to get used to digit grouping after the point.
laanwj merged this on Dec 1, 2014
laanwj closed this on Dec 1, 2014
laanwj referenced this in commit b248a38aa5 on Dec 1, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#5372 Digit group separator(s)