Alternative: delete -printblocktree. I didn't even know it still existed.
Make -printblocktree compatible with headers first #5382
pull sipa wants to merge 1 commits into bitcoin:master from sipa:hfpbt changing 1 files +13 −7-
sipa commented at 9:34 PM on November 26, 2014: member
-
Make -printblocktree compatible with headers first e3f5a4fef7
- sipa force-pushed on Nov 26, 2014
-
sipa commented at 10:02 PM on November 26, 2014: member
- gmaxwell added the label Bug on Nov 27, 2014
-
gmaxwell commented at 4:28 AM on November 27, 2014: contributor
So, ACK the patch (but nit: change ??? to ?? to avoid a trigraph warning), but also ACK removing. My one reservation with removing is that I think we currently have no RPC method to find out about orphaned blocks that we know... otherwise this output is completely redundant with what you can get more easily via rpc.
Actually, scracht that... with getchaintips we can even get the orphans. So ACK removal, since it's redundant to data already better available in RPC. If you want to be snazzy you could feel free to just add a commit removing it on top of this commit fixing it; so a fixed version is in the history if someone wants it. :)
-
laanwj commented at 7:59 AM on November 27, 2014: member
I'm OK with removing it. It was already broken for a long time before I fixed it last time (#3980) which is indicative that almost noone knows about it.
-
- sipa closed this on Nov 27, 2014
- DrahtBot locked this on Sep 8, 2021
