ordering cleanup of Makefile.am #5410

pull Diapolo wants to merge 2 commits into bitcoin:master from Diapolo:cleanup changing 22 files +64 −62

Diapolo commented at 8:32 PM on December 2, 2014: none

No description provided.
fanquake commented at 3:44 AM on December 3, 2014: member

Why does the commit touch hash.ccp ?
Diapolo commented at 8:08 AM on December 3, 2014: none

I included that small change, because the glitch (missing new-line between header sections) was introduced in the recent signature pull and I created the makefile patch then.
laanwj added the label Build system on Dec 5, 2014
Diapolo commented at 11:36 AM on December 9, 2014: none

@laanwj Should this be megerd just before RC phase or now? It's rather ugly to keep this current ^^.
ordering cleanup of Makefile.am 18aae72c03

ordering cleanup after recent merges

- related pulls:
-- block -> primitives rename
-- merkleblock refactoring
- also updates license and copyright year for touched files

d3cd2cc5f7

laanwj commented at 11:02 AM on December 12, 2014: member

Sorry but I'm not going to merge these anymore. An infinite number of these pulls can be created, moving around a few lines here and there, I don't have the time to review and check them all.
laanwj closed this on Dec 12, 2014
Diapolo commented at 12:32 PM on December 12, 2014: none

IMHO a wrong direction here... these pulls could be just merged if marked as ordering cleanup. No need for an in depth code review, but okay...
Diapolo commented at 12:34 PM on December 12, 2014: none

Perhaps Travis could output, if a new build is binary the same as current master, which implies no bad things were added!
laanwj commented at 12:58 PM on December 12, 2014: member

Adding a check for equivalent binaries is a good idea, however it's not only about that. Moving around headers also breaks other pull requests that update the headers. And in generally it generates extra commits, it's just not worth the trouble.

In general: try not to do code changes that don't solve an issue and just make the code prettier from your viewpoint.

(BTW: We've removed mention of file and class order guidelines in commit be0e0703f28c575619cb671a4a44813206a3f388. )
Diapolo deleted the branch on Dec 27, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels