Add time offset into getpeerinfo output #5476

pull paveljanik wants to merge 2 commits into bitcoin:master from paveljanik:timeoffset changing 9 files +44 −6
  1. paveljanik commented at 1:12 PM on December 15, 2014: contributor

    This code extends getpeerinfo output with time offset of the node. The getpeerinfo help text is extended to describe the new variable. Second commit brings this new info to the UI. The Debug window/Peers tab then looks like this (the new part is marked with purple arrow): q This helps to debug the nodes in the network and their time.

  2. Add time offset to getpeerinfo output 26a6bae753
  3. laanwj added the label GUI on Dec 15, 2014
  4. laanwj added the label RPC on Dec 15, 2014
  5. paveljanik commented at 6:22 PM on December 15, 2014: contributor

    When the time offset is 0, UI contains "0" now. It should be "0 s". Or "-"?

  6. Display time offset in the debug window's Peers tab 73caf47dfe
  7. paveljanik force-pushed on Dec 15, 2014
  8. gmaxwell commented at 11:57 PM on December 15, 2014: contributor

    I think it should be zero. Idea ACK.

  9. laanwj commented at 7:03 AM on December 16, 2014: member

    Yes for zero it should be 0 s, for the sake of sanity let's report zero like all other values :)

    I like the concept as well.

  10. paveljanik commented at 7:15 AM on December 16, 2014: contributor

    It is "0 s" now. I do not like "0" because the typical usage (for me) is to scroll down the list of peers and watch their time offset and "0" distracts me, because the "s" letter disappeared. But this is minor nit...

  11. paveljanik commented at 9:41 PM on December 30, 2014: contributor

    Anyone else?

  12. luke-jr commented at 2:57 PM on January 2, 2015: member

    ACK, reviewed code and tested. Looks good.

  13. jgarzik commented at 3:11 PM on January 2, 2015: contributor

    tested ACK

  14. sipa commented at 3:20 PM on January 2, 2015: member

    Untested ACK

  15. laanwj merged this on Jan 2, 2015
  16. laanwj closed this on Jan 2, 2015
  17. laanwj referenced this in commit c986972ad7 on Jan 2, 2015
  18. paveljanik deleted the branch on Jan 2, 2015
  19. MarcoFalke locked this on Sep 8, 2021
Contributors
paveljanikgmaxwelllaanwjluke-jrjgarziksipa
Labels
GUIRPC/REST/ZMQ
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me