Build winshutdownmonitor.cpp on Windows only. #5505

pull paveljanik wants to merge 1 commits into bitcoin:master from paveljanik:nonwin_winshutdownmonitor changing 1 files +5 −2

paveljanik commented at 12:46 PM on December 18, 2014: contributor
The file qt/winshutdownmonitor.cpp is for Windows only. It is marked as such inside (completely #ifdef Windows). But it is compiled and linked in even on non-Windows OS. This change marks it Windows only completely and thus prevents linker warning on newer systems:
```
/usr/bin/ranlib: file: qt/libbitcoinqt.a(qt_libbitcoinqt_a-winshutdownmonitor.o) has no symbols
```
What can be done more: the file bitcoind.cpp contains: #include "winshutdownmonitor.h" - this can be also #ifdefed, but as the included header file is itself #ifdef Windows only, it does not have any effect.
Build winshutdownmonitor.cpp on Windows only. 469d564951
Diapolo commented at 7:22 AM on December 19, 2014: none

Nice, utACK.
fanquake commented at 11:17 AM on December 19, 2014: member

Tested ACK (OSX). Compilation warning disappears and qt_libbitcoinqt_a-winshutdownmonitor.o is no longer built.
jonasschnelli commented at 10:21 AM on December 29, 2014: contributor

Tested. ACK.
laanwj merged this on Dec 29, 2014
laanwj closed this on Dec 29, 2014
laanwj referenced this in commit a99ef7d353 on Dec 29, 2014
alexwzk referenced this in commit 5d837a6ea8 on Dec 29, 2014
paveljanik deleted the branch on Dec 29, 2014
0xartem referenced this in commit 6d5feda1fe on Sep 18, 2018
MarcoFalke locked this on Sep 8, 2021

Contributors