A faster Base58 parser with tolerance for typos: Zero and uppercase 'o' are treated as a lowercase 'o'; lowercase 'L', pipe, and exclamation point are treated as a one.
Typo-tolerant (optimized) Base58 parser #552
pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:base58_liberal_parsing changing 1 files +22 −3-
luke-jr commented at 8:34 PM on October 4, 2011: member
-
When parsing base58 data, accept [0O] as o, and [l|!] as 1 c893b5501b
-
gavinandresen commented at 2:32 PM on October 5, 2011: contributor
No consensus this is a good idea, closing.
- gavinandresen closed this on Oct 5, 2011
-
gmaxwell commented at 7:01 PM on February 17, 2012: contributor
Commenting because I see this is in next-test. I think this is a bad idea, in fact, because its possible to make a typo that currently fails which this corrects to an incorrect passing one. e.g. you type O instead if P (the keys are next to each other) and it corrects to o which happens to pass the crc check. If people are being sloppy in their typing it would be better to find out about it rather than being silently corrected.
- ptschip referenced this in commit a5082df197 on May 10, 2017
- sipa referenced this in commit cc05fa919a on Mar 30, 2019
- sipa referenced this in commit 1e32413e52 on Mar 30, 2019
- sipa referenced this in commit 54245985fb on Mar 31, 2019
- sipa referenced this in commit 3fe71bbd95 on Apr 2, 2019
- LongShao007 referenced this in commit 3d9a3d2063 on Jul 15, 2019
- LongShao007 referenced this in commit 8af66f3427 on Jul 15, 2019
- LongShao007 referenced this in commit 807f206f73 on Jul 15, 2019
- fjahr referenced this in commit 2ebdad772a on Jul 24, 2019
- kallewoof referenced this in commit c866f52e2a on Oct 4, 2019
- Losangelosgenetics referenced this in commit b32369cb03 on Mar 12, 2020
- KolbyML referenced this in commit bc86927231 on Sep 4, 2020
- rajarshimaitra referenced this in commit 0cb116a0bf on Aug 5, 2021
- DrahtBot locked this on Sep 8, 2021
Contributors