clarify obscure uses of EvalScript() #5564

pull ghost wants to merge 1 commits into bitcoin:master from changing 2 files +5 −5

ghost commented at 8:03 PM on December 29, 2014: none

The 3rd argument of EvalScript() is the unsigned int flags, not a bool.
theuni commented at 9:51 PM on December 29, 2014: member

Agree with the change, but the 'true' values would need to be SCRIPT_VERIFY_P2SH in order to make this PR a no-op.
sipa commented at 12:55 AM on December 30, 2014: member

Agree with @theuni.

clarify obscure uses of EvalScript()

The 3rd argument of EvalScript() is the unsigned int flags, not a bool.

de236f57c6

ghost commented at 7:29 AM on December 30, 2014: none

Updated
theuni commented at 6:04 PM on December 31, 2014: member

ut ACK
petertodd commented at 5:10 AM on January 3, 2015: contributor

utACK
fanquake commented at 10:02 AM on January 4, 2015: member

Tested ACK
sipa commented at 3:15 PM on January 4, 2015: member

untested ACK

laanwj commented at 10:50 AM on January 6, 2015: member

03ef452e39dc6bfdd48d3631d1e9c561c34f48fcc63133c3e7b3b3cb747c05b3  bitcoind.a99ef7d.stripped
03ef452e39dc6bfdd48d3631d1e9c561c34f48fcc63133c3e7b3b3cb747c05b3  bitcoind.de236f5.stripped

ACK

laanwj merged this on Jan 6, 2015
laanwj closed this on Jan 6, 2015
laanwj referenced this in commit a89b8371d6 on Jan 6, 2015
unknown deleted the branch on Apr 2, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors