Remove dead BitcoinUnits::id code and update assets-attribution for non-image unit selector #5594

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:no_txt_img_2 changing 3 files +3 −18

luke-jr commented at 3:43 PM on January 3, 2015: member

No description provided.
Remove dead BitcoinUnits::id code and update assets-attribution for non-image unit selector 7eeeac0ff5
Diapolo commented at 5:52 PM on January 3, 2015: none

Tested ACK
laanwj commented at 10:50 AM on January 4, 2015: member

Trivial ACK
laanwj added the label GUI on Jan 4, 2015
in doc/assets-attribution.md:None in 7eeeac0ff5
```
  38 | @@ -39,9 +39,7 @@ Jonas Schnelli
  39 |      src/qt/res/icons/connect[0-3].png, src/qt/res/icons/eye_minus.png,
  40 |      src/qt/res/icons/eye_plus.png, src/qt/res/icons/verify.png,
  41 |      src/qt/res/icons/tx_inout.png, src/qt/res/icons/tx_input.png,
```
fanquake commented at 10:56 AM on January 4, 2015:

care to fix the typo here as well? Save another commit s/tx_inout/tx_input

luke-jr commented at 12:03 PM on January 4, 2015:

? there's 2 files, both listed

fanquake commented at 12:27 PM on January 4, 2015:

eh sorry, misread by me.

laanwj commented at 2:48 PM on January 4, 2015:

inout is correct in this case
fanquake commented at 10:56 AM on January 4, 2015: member

Tested ACK
jonasschnelli commented at 2:10 PM on January 4, 2015: contributor

ACK
jtimon commented at 6:54 PM on January 4, 2015: contributor

ACK

in doc/assets-attribution.md:None in 7eeeac0ff5

  44 | -    src/qt/res/src/bitcoin.svg, src/qt/res/src/clock*.svg,
  45 | -    src/qt/res/src/connect*.svg, src/qt/res/src/mine.svg,
  46 | -    src/qt/res/src/qt.svg, src/qt/res/src/tx*.svg,
  47 | +    src/qt/res/src/verify.svg, src/qt/res/src/bitcoin.svg,
  48 | +    src/qt/res/src/clock*.svg, src/qt/res/src/connect*.svg,
  49 | +    src/qt/res/src/mine.svg, src/qt/res/src/qt.svg, src/qt/res/src/tx*.svg,

jonasschnelli commented at 7:03 PM on January 4, 2015:

nit: normally we have two entries per line.

laanwj merged this on Jan 5, 2015
laanwj closed this on Jan 5, 2015
laanwj referenced this in commit a043facf5a on Jan 5, 2015
luke-jr deleted the branch on Jan 5, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels