tests: run sanity checks in tests too #5604

1. 
   theuni commented at 3:28 AM on January 6, 2015: member

   I've recently stumbled upon a bad compiler/libstdc++ runtime combination where these sanity checks fail in bitcoind. If they are going to fail in bitcoind, they should fail in the tests as well.

   Confirmed failing as expected on this combination (osx 10.9 + vanilla clang 3.4 + macosx-version-min=10.8).

2. tests: run sanity checks in tests too

   If these are going to fail in bitcoind, they should fail in the tests as well.

   d58c5d6f21
3. 
   laanwj commented at 9:27 AM on January 6, 2015: member

   ACK (although something could be said for putting the ECC test in key_tests instead, but ECC sanity is a core-enough concern to bitcoin that it makes sense as a general sanity check)

4. laanwj added the label Tests on Jan 6, 2015
5. 
   fanquake commented at 10:52 AM on January 8, 2015: member

   ACK

6. laanwj merged this on Jan 8, 2015
7. laanwj closed this on Jan 8, 2015

   ---

8. laanwj referenced this in commit c5e0aef5c4 on Jan 8, 2015
9. laanwj referenced this in commit 263b65ebf0 on Jan 8, 2015
10. 
    laanwj commented at 11:08 AM on January 8, 2015: member

    Also cherry-picked to 0.10 as 263b65ebf0ce0beae5622a533234c8f897aec4e1

11. laanwj added this to the milestone 0.10.0 on Jan 8, 2015
12. reddink referenced this in commit 34d8632197 on May 27, 2020
13. MarcoFalke locked this on Sep 8, 2021

Milestone
0.10.0