Improve robustness of DER recoding code #5640

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2015_01_openssl_robustness changing 1 files +12 −1

laanwj commented at 10:20 AM on January 11, 2015: member

Add some defensive programming on top of #5634.

This copies the respective OpenSSL code in ECDSA_verify in OpenSSL pre-1.0.1k (e.g. https://github.com/openssl/openssl/blob/OpenSSL_1_0_1j/crypto/ecdsa/ecs_vrf.c#L89) more closely.

As reported by @sergiodemianlerner.
laanwj added the label Validation on Jan 11, 2015
sipa commented at 3:53 PM on January 11, 2015: member

Untested ACK
gmaxwell commented at 6:53 PM on January 11, 2015: contributor

ACK
laanwj force-pushed on Jan 12, 2015

Improve robustness of DER recoding code

Add some defensive programming on top of #5634.

This copies the respective OpenSSL code in ECDSA_verify in
OpenSSL pre-1.0.1k (e.g. https://github.com/openssl/openssl/blob/OpenSSL_1_0_1j/crypto/ecdsa/ecs_vrf.c#L89)
more closely.

As reported by @sergiodemianlerner.

c6b7b29f23

laanwj force-pushed on Jan 12, 2015
laanwj commented at 7:59 AM on January 12, 2015: member

Added a comment
laanwj merged this on Jan 12, 2015
laanwj closed this on Jan 12, 2015
laanwj referenced this in commit 8d0fd46460 on Jan 12, 2015
laanwj referenced this in commit 12b7c444f0 on Jan 12, 2015
laanwj referenced this in commit 037bfefe6b on Jan 12, 2015
laanwj referenced this in commit f19dded6e4 on Jan 12, 2015
wtogami referenced this in commit af4beb8e70 on Jan 13, 2015
Gitju referenced this in commit 0dbd805a8b on Jan 15, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)