Restore RPC HTTP keepalives to default. #5674

1. 
   gmaxwell commented at 2:08 pm on January 16, 2015: contributor

   This avoids a regression for issues like #334 where high speed repeated connections eventually run the HTTP client out of sockets because all of theirs end up in time_wait.

   Maybe the trade-off here is suboptimal, but if both choices will fail then we prefer fewer changes until the root cause is solved.

2. Restore RPC HTTP keepalives to default.

   This avoids a regression for issues like #334 where high speed
    repeated connections eventually run the HTTP client out of
    sockets because all of theirs end up in time_wait.
   
   Maybe the trade-off here is suboptimal, but if both choices will
    fail then we prefer fewer changes until the root cause is solved.

   7d2cb48511
3. 
   jgarzik commented at 2:08 pm on January 16, 2015: contributor

   ACK
4. 
   laanwj commented at 2:15 pm on January 16, 2015: member

   utACK
5. 
   gmaxwell commented at 2:16 pm on January 16, 2015: contributor

   Lets see if this breaks the tests expectations.
6. 
   jonasschnelli commented at 2:27 pm on January 16, 2015: contributor

   Http basics.py test will fail. I’ll fix this soon and supply a commit.
7. 
   jonasschnelli commented at 3:35 pm on January 17, 2015: contributor

   @gmaxwell if you pull in https://github.com/jonasschnelli/bitcoin/commit/660d6ce553195a5f6a94010c91822e786c3b47c1 travis will be happy. I also changed the HTTP method from GET to POST which is the correct method for JSON RPC.
8. [QA] fix httpbasic keep-alive test 1a25a7edf8
9. laanwj merged this on Jan 19, 2015
10. laanwj closed this on Jan 19, 2015

    ---

11. laanwj referenced this in commit a0abff2755 on Jan 19, 2015
12. gmaxwell referenced this in commit 186a517692 on Jan 19, 2015
13. 
    laanwj commented at 11:32 am on January 19, 2015: member

    Backported into 0.10 branch as 186a517
14. laanwj added this to the milestone 0.10.0 on Jan 19, 2015
15. wtogami referenced this in commit 7b0275ada2 on Jan 23, 2015
16. laanwj referenced this in commit 1065bb1cd2 on Aug 28, 2015
17. laanwj referenced this in commit ea55964826 on Sep 2, 2015
18. laanwj referenced this in commit 49183bb7fb on Sep 2, 2015
19. laanwj referenced this in commit 40b556d374 on Sep 3, 2015
20. reddink referenced this in commit ca92a6ed99 on May 27, 2020
21. MarcoFalke locked this on Sep 8, 2021

Contributors
gmaxwell jgarzik laanwj jonasschnelli

Milestone
0.10.0