add new osx dmg background picture #5683

pull jonasschnelli wants to merge 4 commits into bitcoin:master from jonasschnelli:2015/01/dmg_background changing 8 files +13 −11

jonasschnelli commented at 9:03 PM on January 19, 2015: contributor

No description provided.
jonasschnelli commented at 9:05 PM on January 19, 2015: contributor

prebuilt binaries: https://builds.jonasschnelli.ch/pulls/5683/
in contrib/macdeploy/fancy.plist:None in 6299d3e69f outdated
```
   9 | @@ -10,7 +10,7 @@
  10 |  		<integer>620</integer>
  11 |  	</array>
  12 |  	<key>background_picture</key>
  13 | -	<string>background.png</string>
  14 | +	<string>background.tiff</string>
```
jonasschnelli commented at 9:07 PM on January 19, 2015:

tiff is used to include a retina and non-retina background (according to https://developer.apple.com/library/mac/documentation/GraphicsAnimation/Conceptual/HighResolutionOSX/Optimizing/Optimizing.html)
theuni commented at 1:05 AM on January 20, 2015: member

@jonasschnelli Please review/pull in the top 3 commits here: https://github.com/theuni/bitcoin/commits/osx-background-image . They'll fix OSX builds from Linux/Gitian after these changes.

These sync up the way that we deal with the background images. Prior to these changes, different paths were used depending whether the build was native OSX or Linux cross.

Since Linux can't mount the image and run the applescripts, we have to use a pre-generated DS_Store file to grab the proper layout. Also, Linux can't set the "invisible" property on the background image, so we work-around by moving it into a ".background" folder, which OSX hides by default.

Here's a cross-built dmg to verify that everything looks correct: https://bitcoincore.org/cfields/Bitcoin-Qt-82f9b72c.dmg

As for the changes themselves, IMO the text would look nicer centered. Also, the arrow looks a bit... cartooney.
laanwj added the label GUI on Jan 20, 2015
laanwj added the label Mac on Jan 20, 2015
jonasschnelli force-pushed on Jan 20, 2015
jonasschnelli commented at 8:26 AM on January 20, 2015: contributor

@theuni Perfect. I reviewed the three commits (82f9b72, e9383dc, 439b352). Looks good to me. ACK with the nit/question of the output size factor.

Also updated the image once again to center the text. I was getting inspired by the firefox background image (there the "Firefox" text is also left aligned). But centered looks good IMO.
osx packaging: move background image to .background to match gitian builds
Also increase temp dmg filesize to account for a bigger background image
88a797320a

osx packaging: switch background image to background.tiff

Also do a bit of cleanup:
 - Make the background name a variable so it's easier to change
 - Add proper make dependencies

997cab78cb

osx packaging: update DS_Store after background changes 48bebcca79
add new osx dmg background picture 95ef87c75e
jonasschnelli force-pushed on Jan 20, 2015
jonasschnelli commented at 8:39 AM on January 20, 2015: contributor

pulled in 82f9b72, e9383dc, 439b352
jonasschnelli commented at 2:23 PM on January 20, 2015: contributor

current screen:
jonasschnelli commented at 2:23 PM on January 20, 2015: contributor

binary to test: https://bitcoin.jonasschnelli.ch/pulls/5683/
fanquake commented at 4:24 AM on January 23, 2015: member

ACK
laanwj merged this on Jan 29, 2015
laanwj closed this on Jan 29, 2015
laanwj referenced this in commit c7b22aa0ac on Jan 29, 2015
DrahtBot locked this on Sep 8, 2021

Contributors

Labels