Includes: Cleanup includes #5697

1. 
   jtimon commented at 1:03 pm on January 23, 2015: contributor

   Separated from #5681 (as explained there) to also include #5696 and to become a single commit cleanup (after those two and maybe other preparations have been merged).
2. laanwj added the label UTXO Db and Indexes on Jan 26, 2015
3. laanwj removed the label UTXO Db and Indexes on Jan 26, 2015
4. laanwj added the label Improvement on Jan 26, 2015
5. jtimon force-pushed on Feb 3, 2015
6. jtimon force-pushed on Feb 3, 2015
7. jtimon force-pushed on Feb 6, 2015
8. jtimon renamed this:
   Cleanup: Don't include main.h from any other header
   Cleanup includes after some code movements around (mostly from main)
   on Feb 6, 2015
9. jtimon renamed this:
   Cleanup includes after some code movements around (mostly from main)
   Cleanup includes after some code movements (mostly from main)
   on Feb 6, 2015
10. 
    jtimon commented at 7:50 pm on February 13, 2015: contributor

    closing for now
11. jtimon closed this on Feb 13, 2015

    ---

12. jtimon reopened this on Jul 5, 2015

    ---

13. jtimon renamed this:
    Cleanup includes after some code movements (mostly from main)
    Includes: Move some from main.h to main.cpp and compile
    on Jul 5, 2015
14. jtimon force-pushed on Jul 5, 2015
15. 
    jtimon commented at 1:55 am on July 5, 2015: contributor

    I know this will be more interesting after #6051 and #6335 but why keep waiting? This is good already.
16. 
    Diapolo commented at 6:46 am on July 5, 2015: none

    @jtimon But it fails Travis :-/.
17. jtimon force-pushed on Jul 5, 2015
18. 
    jtimon commented at 10:45 am on July 5, 2015: contributor

    Fixed –disable-wallet build.
19. jtimon force-pushed on Jul 5, 2015
20. jtimon renamed this:
    Includes: Move some from main.h to main.cpp and compile
    Includes: Cleanup includes
    on Jul 5, 2015
21. 
    jtimon commented at 12:39 pm on July 5, 2015: contributor

    Updated. Now also cleaning up net.h and wallet/ a little bit. Of course, adding the missing includes that are discovered.
22. jtimon force-pushed on Jul 5, 2015
23. jtimon force-pushed on Jul 5, 2015
24. jtimon force-pushed on Jul 5, 2015
25. 
    jtimon commented at 9:24 pm on July 5, 2015: contributor

    Sorry, updated again.
26. jtimon force-pushed on Jul 6, 2015
27. 
    jtimon commented at 11:24 pm on July 6, 2015: contributor

    Rebased
28. 
    jgarzik commented at 11:50 pm on July 6, 2015: contributor

    concept ACK - however this sort of PR needs constant rebasing. Usually better to break it up into even smaller chunks than modifying 40+ files in one go.
29. 
    jtimon commented at 7:43 am on July 7, 2015: contributor

    Yes, that’s why I try to avoid making these cleanups after the code moves that make them possible and not at the same time (so that the moves are less painful). But they keep accumulating… The need for constant rebases and lack of review is why I closed it last time, and When I get bored of I will likely close it once again. But, yes, smaller pieces (maybe small enough to get into the trivial branch while keeping the trivial branch itself maintainable) is a good suggestion, although I would really prefer that one day it just got merged once and for all (innocent me).
30. 
    Diapolo commented at 7:50 am on July 7, 2015: none

    I always think this is a valuable work, but doesn’t get much review time or seems to trivial for getting reviewed. Perhaps the trivial branch is the better place, but IMHO the trivial cycles should be shorter also.
31. 
    jgarzik commented at 6:55 pm on July 23, 2015: contributor

    ACK. Merge or close.
32. TRIVIAL: Missing includes 9dd793f499
33. Includes: Cleanup around net main and wallet

    -Move from .h to .cpp: in main, net and wallet
    -Remove unnecessary #include "main.h"
    -Cleanup some wallet files includes

    60c8bac77c
34. jtimon force-pushed on Jul 23, 2015
35. 
    jtimon commented at 7:13 pm on July 23, 2015: contributor

    Sorry, I didn’t realized this needed a trivial rebase (a using namespace std near a newly added #include <boost/foreach.hpp> in walletmodel.cpp).
36. laanwj merged this on Jul 27, 2015
37. laanwj closed this on Jul 27, 2015

    ---

38. laanwj referenced this in commit ca37e0f339 on Jul 27, 2015
39. 
    laanwj commented at 12:42 pm on July 27, 2015: member

    ACK - but let’s do this only once per major release
40. 
    jtimon commented at 10:36 am on July 28, 2015: contributor

    Limiting to at most one big include cleanup per major release sounds reasonable. I’m not sure I will ever do another one as big as this one though (and smaller ones can be made part of the relevant PR or via the trivial branch).
41. str4d referenced this in commit 1ff0a063c0 on Jul 13, 2017
42. str4d referenced this in commit 3a90a8519f on Nov 9, 2017
43. str4d referenced this in commit c84abf0194 on Dec 19, 2017
44. str4d referenced this in commit 1f993269ef on Apr 5, 2018
45. str4d referenced this in commit e86ad1d610 on Jun 27, 2019
46. str4d referenced this in commit 4fc6410110 on Aug 13, 2020
47. str4d referenced this in commit d0ed2a7c81 on Feb 16, 2021
48. zkbot referenced this in commit 89d9e557e1 on Feb 17, 2021
49. str4d referenced this in commit 1a85cc8817 on Feb 17, 2021
50. str4d referenced this in commit 8242ad0b4b on Feb 18, 2021
51. MarcoFalke locked this on Sep 8, 2021

Contributors
jtimon Diapolo jgarzik laanwj

Labels
Refactoring