MOVEONLY: Policy: Move some policy code #6335

pull jtimon wants to merge 2 commits into bitcoin:master from jtimon:policy-moveonly-0.11.99 changing 16 files +250 −214

jtimon commented at 5:16 PM on June 24, 2015: contributor

Move policy code out of main (and policy/standard). Nobody seemed to disagree with this part in any of the multiple versions of #6068 and related PRs. This is trivially non-risky, but this PR will be closed when a bitcoin/0.12 branch is created (unless it has been merged first).
jtimon force-pushed on Jun 24, 2015
jonasschnelli commented at 6:24 PM on June 24, 2015: contributor

Code Review ACK.
petertodd commented at 7:24 PM on June 24, 2015: contributor

utACK (mostly concept ACK, w/ some code review)
paveljanik commented at 2:48 PM on June 25, 2015: contributor

utACK
theuni commented at 9:53 PM on June 25, 2015: member

Confirmed move-only other than the std namespace changes. utACK other than the nit above.
jtimon commented at 7:06 AM on June 26, 2015: contributor

@theuni re additional declaration. It was to not leave the comment alone until it is replaced with the CStandardPolicy method that will replace it in https://github.com/jtimon/bitcoin/commit/3fdcfedadafebb11f5ee01f10ef2c0f0f98c74d5#diff-d22bc3e058f8982972e2eb381a1df668L35 but I'm happy to remove that line if it doesn't make sense to anyone else. For me having the comment ready there is enough.
btcdrak commented at 12:53 PM on June 26, 2015: contributor

utACK, needs rebase
morcos commented at 3:39 PM on June 26, 2015: member

ACK (before the merge conflict)
Policy: MOVEONLY: Create policy/policy.h with some constants 627b9deff4

Policy: MOVEONLY: 3 functions to policy.o:

- [script/standard.o] IsStandard
- [main.o] IsStandardTx
- [main.o] AreInputsStandard

Also, don't use namespace std in policy.cpp

9238ecb417

jtimon force-pushed on Jun 26, 2015
jtimon commented at 4:03 PM on June 26, 2015: contributor

Rebased
luke-jr commented at 6:44 PM on June 27, 2015: member

Concept ACK (did not confirm MOVEONLY since there are other ACKs here).
jtimon commented at 12:18 PM on June 30, 2015: contributor

@laanwj @sipa ping
laanwj added the label Refactoring on Jul 2, 2015
laanwj merged this on Jul 6, 2015
laanwj closed this on Jul 6, 2015
laanwj referenced this in commit 9546a977d3 on Jul 6, 2015
zkbot referenced this in commit 63c3d1ec94 on Dec 17, 2019
furszy referenced this in commit a5265a4db4 on Jun 27, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#6068 Policy: Create CPolicy interface and CStandardPolicy class implementing it #32129 doc: Update comments for AreInputsStandard to match code