Add more information to errors in ReadBlockFromDisk #5710

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2015_01_block_corrupt_debug changing 2 files +11 −4

laanwj commented at 9:16 AM on January 26, 2015: member

A lot of times, disk corruption problems appear here. To facilitate debugging and troubleshooting, add position information to the error messages.

I've tested all the error messages by injecting errors.
laanwj added the label Docs and Output on Jan 26, 2015
pstratem commented at 1:28 AM on January 29, 2015: contributor

I'm trying to trigger this code path on the system I have that produces this error during normal operation without fault injection.
jonasschnelli commented at 9:12 AM on February 5, 2015: contributor

utACK

Add more information to errors in ReadBlockFromDisk

A lot of times, disk corruption problems appear here.
To facilitate debugging and troubleshooting, add position information
to the error messages.

f5791c6ae3

laanwj force-pushed on Feb 5, 2015
fanquake commented at 1:21 PM on February 16, 2015: member

utACK
harding commented at 2:01 PM on February 16, 2015: contributor

I ran this for several days without problem on a machine that once had bitcoind die on ReadBlockFromDisk. (Alas, I couldn't reproduce the previous error even with a full reindex.)

I did not inject errors to test the code paths.
sipa merged this on Feb 16, 2015
sipa closed this on Feb 16, 2015
sipa referenced this in commit 175d86e633 on Feb 16, 2015
pstratem commented at 9:50 PM on February 16, 2015: contributor

Oops forgot to mention.

I tested this on a system which had repeatable ReadBlockFromDisk issues and this worked correctly.
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels