Change Coin Control first column label from "1" to " " for Qt4 binary #5720

fsb4000 commented at 7:26 PM on January 28, 2015: contributor

fix issue #5716

Reproduce this bug on Windows:

Simple compile bitcoin with Qt 4.8.6

jonasschnelli commented at 7:56 PM on January 28, 2015: contributor

Works for me. NIT: would it be possible to use a better commit and push-request title? Keep the "fix issue #5716" as message but use a different title. ACK when fixing the NIT.

Tested with gitian build: https://bitcoin.jonasschnelli.ch/pulls/5720/

After the pull it looks like:

bildschirmfoto 2015-01-28 um 20 50 39

fsb4000 renamed this:
~~fix issue #5716~~
Change Coin Control first column label from "1" to " " for Qt4 binary
on Jan 28, 2015

fsb4000 commented at 8:06 PM on January 28, 2015: contributor

@jonasschnelli Sorry, but how to change commit title?

jonasschnelli commented at 8:17 PM on January 28, 2015: contributor

@fsb4000 is very easy. Check: http://stackoverflow.com/questions/179123/edit-an-incorrect-commit-message-in-git Then do a --force push afterwards. something like git push <repo> master:patch-3 --force (or similar, didn't try)

fsb4000 commented at 8:34 PM on January 28, 2015: contributor

@jonasschnelli Ty, It seems I did it

C:\GitHub\bitcoin>git commit -a --amend -m "Change Coin Control first column label"
[patch-3 2d63205] Change Coin Control first column label
 1 file changed, 2 insertions(+)

C:\GitHub\bitcoin>git push --force
Counting objects: 1, done.
Writing objects: 100% (1/1), 204 bytes | 0 bytes/s, done.
Total 1 (delta 0), reused 0 (delta 0)
To https://github.com/fsb4000/bitcoin.git
 + 502f592...2d63205 patch-3 -> patch-3 (forced update)

C:\GitHub\bitcoin>

jonasschnelli commented at 10:07 PM on January 28, 2015: contributor

ACK.

fanquake commented at 1:13 AM on January 29, 2015: member

ACK

laanwj added the label GUI on Jan 29, 2015

Change Coin Control first column label 55eade9d46

in src/qt/coincontroldialog.cpp:None in 2d6320569e outdated

 116 | @@ -117,6 +117,8 @@ CoinControlDialog::CoinControlDialog(QWidget *parent) :
 117 |      // (un)select all
 118 |      connect(ui->pushButtonSelectAll, SIGNAL(clicked()), this, SLOT(buttonSelectAllClicked()));
 119 |  
 120 | +    ui->treeWidget->headerItem()->setText(COLUMN_CHECKBOX, QString());

jonasschnelli commented at 8:44 AM on January 29, 2015:

little nit: wouldn't it be good to add a comment above this line saying that this is a workaround added because of a Qt4 bug? Maybe in far future we once drop Qt4 support and should remove such "hacks"

fsb4000 commented at 9:09 AM on January 29, 2015: contributor

@jonasschnelli

little nit: wouldn't it be good to add a comment above this line saying that this is a workaround added because of a Qt4 bug? Maybe in far future we once drop Qt4 support and should remove such "hacks"

done

jonasschnelli commented at 9:10 AM on January 29, 2015: contributor

ReACK.

jonasschnelli commented at 9:17 AM on January 29, 2015: contributor

@fsb4000 mind taking deeper look in the reason why there is a "1" as table header string by default? This could be a symptom of a deeper bug.

fsb4000 commented at 9:23 AM on January 29, 2015: contributor

@jonasschnelli

I tried build with Qt 5(5.3.2 and 5.4.0): no bug.
I tried build with change the string to "55" (this string: https://github.com/bitcoin/bitcoin/blob/master/src/qt/forms/coincontroldialog.ui#L444 ) Coin Control first column label was "55"
I tried build with change the string to " "(one space)(this string: https://github.com/bitcoin/bitcoin/blob/master/src/qt/forms/coincontroldialog.ui#L444 ) Coin Control first column label was "1"
I tried build with change the string to " "(two "spaces")(this string: https://github.com/bitcoin/bitcoin/blob/master/src/qt/forms/coincontroldialog.ui#L444 ) Coin Control first column label was "1"

laanwj commented at 10:04 AM on January 29, 2015: member

I found out the reason for the numbers: by default, the table widget is a spreadsheet-like widget which numbers the columns. If you set a title for a column, it overrides the number.

Interestingly, it doesn't seem possible to get this same change through the uic (e.g. by changing coincontroldialog.ui). We set an empty string there but no code is generated for that in ui_coincontroldialog.h!

fsb4000 commented at 10:14 AM on January 29, 2015: contributor

@laanwj cool. I'm too late :( Anyway I did simple Qt app with only one Widget: CoinControl https://yadi.sk/d/DZ1vVPBKeKG7o It looks like: test So laanwj is right, not only first but all columns are numbered in Qt4

laanwj merged this on Jan 29, 2015

laanwj closed this on Jan 29, 2015

laanwj referenced this in commit 7620ef9e7e on Jan 29, 2015

laanwj referenced this in commit b61940b3a1 on Jan 29, 2015

fsb4000 deleted the branch on Feb 8, 2015

reddink referenced this in commit 1897aaac73 on May 27, 2020

MarcoFalke locked this on Sep 8, 2021