The default of zero is never correct nor desired.
Edit Bitcoin-Qt.conf and remove "nTransactionFee" to see the effect of this change which is limited to the default value in the custom fee of the send coins dialog.
Related question: It is additionally unclear why wallet.h contains this. Wouldn't it make more sense to define this as the min fee as well or get rid of it?
//! -paytxfee default
static const CAmount DEFAULT_TRANSACTION_FEE = 0;
NAK. The default of zero is completely reasonable, and allows transactions to pay their way with priority where possible and available.
To be more clear, this doesn't change anything that you are concerned about. The Recommended fee is used by default. This commit only changes the default value that is the custom fee which isn't used unless you manually select it.
Additionally did you know "Send as zero-fee transaction if possible" is disabled by default in the wallet GUI? See fSendFreeTransactions
Yep, I knew that. Still isn't obvious what you're trying to accomplish here. Can you explain the bad behavior you're trying to correct for me?
Prior to the patch the custom fee box is zero which is never usable. This merely sets that value to a sane default ... which is not actually used unless you select the Custom fee radio.
It is separately necessary to check "Send as zero-fee transaction if possible" if you really want to pay with priority, in which case both the Recommended and Custom fee are ignored.
(Your concern as stated in the NAK not how the code currently operates.)
NOTE: I didn't change DEFAULT_TRANSACTION_FEE, that was merely a related question.
Does anyone else involved with the wallet have an opinion here? @jonasschnelli @cozz?
@wtogami i cannot follow the intent of this PR. Could you explain more in detail whats the benefit of this change?
Before this PR i have a std.fee of 0.01mBTC/kb:
After this PR i still have std fee of 0.01mBTC/kb.
Tend to NACK because i can't see the benefit and this might bring up new issues.
before:
after:
At my view this PR is trivial.
No new issues.
ACK
I'm still not convinced.
After looking again i see 0.00000 as default fee.
I stepped to code and got false while eval settings.contains("nTransactionFee") (i use the std. config with --regtest added).
And why there is a call to GetFeePerK() for a absolute (not per KB) fee?
And why there is a call to GetFeePerK() for a absolute (not per KB) fee?
Actually here per KB fee: (sendcoindialog.cpp)
CWallet::minTxFee.GetFeePerK()
(amount.h) (class CFeeRate)
CAmount GetFeePerK() const { return GetFee(1000); } // satoshis-per-1000-bytes
(amount.cpp)
CAmount CFeeRate::GetFee(size_t nSize) const
{
CAmount nFee = nSatoshisPerK*nSize / 1000;
if (nFee == 0 && nSatoshisPerK > 0)
nFee = nSatoshisPerK;
return nFee;
}
I'm still not convinced. After looking again i see 0.00000 as default fee.
You see 0.000000 because the parameter(Qsettings) is already existed. This value changes only when you run first time.
I don't know about Mac and Linux but if you delete parameter
HKEY_CURRENT_USER\Software\Bitcoin\Bitcoin-Qt-testnet\nTransactionFee at Windows you'll get my result
I still don't understand this. The default fee in Bitcoin Core is zero (absent smartfee). Having to hit a bunch of buttons just to get back to zero would be annoying. I'm probably misunderstanding, but I tried to get warren to help me understand and failed. :(
I still don't understand this. The default fee in Bitcoin Core is zero (absent smartfee). Having to hit a bunch of buttons just to get back to zero would be annoying. I'm probably misunderstanding, but I tried to get warren to help me understand and failed. :(
You don't need change back to zero. If you want send with zero fee you should check ui->checkBoxFreeTx (in order to fSendFreeTransactions=true) Your zero fee is ignored. The sequence:
CAmount nFeeNeeded = GetMinimumFee(nBytes, nTxConfirmTarget, mempool);
https://github.com/bitcoin/bitcoin/blob/master/src/wallet.cpp#L1739 6)function GetMininumFee https://github.com/bitcoin/bitcoin/blob/master/src/wallet.cpp#L1818
CAmount CWallet::GetMinimumFee(unsigned int nTxBytes, unsigned int nConfirmTarget, const CTxMemPool& pool)
{
// payTxFee is user-set "I want to pay this much"
CAmount nFeeNeeded = payTxFee.GetFee(nTxBytes);
// user selected total at least (default=true)
if (fPayAtLeastCustomFee && nFeeNeeded > 0 && nFeeNeeded < payTxFee.GetFeePerK())
nFeeNeeded = payTxFee.GetFeePerK();
// User didn't set: use -txconfirmtarget to estimate...
if (nFeeNeeded == 0)
nFeeNeeded = pool.estimateFee(nConfirmTarget).GetFee(nTxBytes);
// ... unless we don't have enough mempool data, in which case fall
// back to a hard-coded fee
if (nFeeNeeded == 0)
nFeeNeeded = minTxFee.GetFee(nTxBytes);
// prevent user from paying a non-sense fee (like 1 satoshi): 0 < fee < minRelayFee
if (nFeeNeeded < ::minRelayTxFee.GetFee(nTxBytes))
nFeeNeeded = ::minRelayTxFee.GetFee(nTxBytes);
// But always obey the maximum
if (nFeeNeeded > maxTxFee)
nFeeNeeded = maxTxFee;
return nFeeNeeded;
}
As you can see here your zero fee will be overwritten.
As you can see here your zero fee will be overwritten.
Yes, it will be, if you don't meet the basic criteria for relaying. I wrote that code.
I am not trying to debate the free transaction behavior. I am trying to oppose what sound like this idea that there is some minimum fee on the bitcoin network which is something other than zero.
I'm going to close this pull - from the discussion it looks to be controversial to change the default. The value of the QSetting in question is only used in the GUI field shown in the screenshots, and it's value is easily changed in the GUI for people that want to change it.