Minor fixes

lucayepa commented at 7:10 am on February 2, 2015: contributor

Note that the modified HelpMessage and HelpMessageCli will require translation changes in Transifex for the keys.

Trivial - no need to have a README.md not ASCII c4ddc016f1

Better error explanation for "Failed to connect best block" 9867b1d168

Fix - Newline at the end of INSTALL a29c99d602

Fix - HelpMessage correctly formatted for SVGA text mode (132 chars) 943c9021af

Fix - HelpMessageCli correctly formatted for SVGA text mode (132 chars) 5cb0d561be

in INSTALL: in 5cb0d561be

1@@ -2,4 +2,4 @@ Building Bitcoin
2 
3 See doc/build-*.md for instructions on building bitcoind,
4 the intended-for-services, no-graphical-interface, reference
5-implementation of Bitcoin.
6\ No newline at end of file
7+implementation of Bitcoin.

fanquake commented at 8:25 am on February 2, 2015:

What exactly does this fix?

laanwj commented at 8:53 am on February 2, 2015:

Yes, don’t make these kind of pointless changes please.

lucayepa commented at 4:13 pm on February 2, 2015:

It is not a pointless change. That file is used by sysadmin to install the software. And when you are a sysadmin and “cat INSTALL.md” does not bring you on the same line, you think you missed something of the original package.

in src/init.cpp: in 5cb0d561be

0@@ -1,5 +1,5 @@
1 // Copyright (c) 2009-2010 Satoshi Nakamoto
2-// Copyright (c) 2009-2014 The Bitcoin Core developers
3+// Copyright (c) 2009-2015 The Bitcoin Core developers
4 // Distributed under the MIT software license, see the accompanying

fanquake commented at 8:25 am on February 2, 2015:

Please don’t change this date.

lucayepa commented at 4:15 pm on February 2, 2015:

I’m not interested in changing this date (obviously), but may I ask why?

jonasschnelli commented at 8:34 am on February 2, 2015: contributor

ACK init.cpp and bitcoin-cli.cpp changes (except copyright year header) NACK INSTALL.md and README.md changes. It would also be nice if this could get squashed to 1 commit.

in README.md: in 5cb0d561be

59@@ -60,7 +60,7 @@ submit new unit tests for old code. Unit tests can be compiled and run (assuming
60 
61 Every pull request is built for both Windows and Linux on a dedicated server,
62 and unit and sanity tests are automatically run. The binaries produced may be
63-used for manual QA testing — a link to them will appear in a comment on the
64+used for manual QA testing -- a link to them will appear in a comment on the

laanwj commented at 8:47 am on February 2, 2015:

NACK on this. Using UTF-8 to pretty up the text is fine in 2015.

lucayepa commented at 4:46 pm on February 2, 2015:

This file is used on servers as well. You “cat”, “less” or “view” it. A lot of servers are set on ASCII-only in order to be less buggy while editing configuration files. Call it UX for sysadmin, but all the servers I work with display those chars as spurious chars. If you browse projects as gcc, libc and a lot of others, you find that they are in 2015 too, but they care about the “sysadmin UX” more than we do.

laanwj commented at 8:53 am on February 2, 2015: member

Also NACK on breaking up the translation messages. This just gives the translators extra work without gain (and they’ll spend more time correlating the various messages to keep track of the context).

Remember that messages won’t have the same width in different languages.

If your intent is to format to a certain column width you could use FormatParagraph in utilstrencodings to do so programmatically without changing a single translation message.

laanwj commented at 8:55 am on February 2, 2015: member

Closing this. Sorry for that, but we’re drowning in pull requests and have to prioritize.

laanwj closed this on Feb 2, 2015

lucayepa commented at 4:47 pm on February 2, 2015: contributor

I’ll work on FormatParagraph to not break the strings. Thank you for the hint.

lucayepa commented at 8:18 am on February 4, 2015: contributor

Made the #5734 with FormatParagraph to not break the strings.

MarcoFalke locked this on Sep 8, 2021

Minor fixes #5734