No description provided.
[Qt] add bitcoin logo to about screen #5753
pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2015/01/qt_about changing 2 files +83 −0-
jonasschnelli commented at 3:00 PM on February 4, 2015: contributor
- jonasschnelli force-pushed on Feb 4, 2015
-
fanquake commented at 3:48 PM on February 4, 2015: member
- jonasschnelli force-pushed on Feb 4, 2015
-
jonasschnelli commented at 7:35 PM on February 4, 2015: contributor
Now it should be Qt4 compatible.
Screen before and after:
- jonasschnelli force-pushed on Feb 4, 2015
- jonasschnelli force-pushed on Feb 4, 2015
-
[Qt] add bitcoin logo to about screen d67a642392
- jonasschnelli force-pushed on Feb 4, 2015
-
jonasschnelli commented at 8:01 PM on February 4, 2015: contributor
Linux:
Before
After:
-
paveljanik commented at 8:29 PM on February 4, 2015: contributor
ACK minor NIT: on testnet/regtest, the color is not as we are used to :-)
-
jonasschnelli commented at 8:44 PM on February 4, 2015: contributor
@paveljanik Yes. This is a feature ... cough slightly. Having a blue/green icon in testnet/regtest mode is fine IMO.
-
paveljanik commented at 8:52 PM on February 4, 2015: contributor
BTW - I was talking about the color of the new added icon on the About window... I like the color of the intro image (both green and blue one!). Would like to see the same color in the About window as well :-) But you can safely ignore this :-)
-
jonasschnelli commented at 9:03 PM on February 4, 2015: contributor
@paveljanik Yes. I know what you meant with that. I was just cough slightly because i was aware of this inconsistence. It would certainly be fixable somehow. But the color of the icon gets rewritten and cached at the very beginning of the qt app cycle. I think it's not worth the effort because the green/blue icon will probably only popups on devs screens.
-
paveljanik commented at 9:06 PM on February 4, 2015: contributor
Agreed, sure.
-
fanquake commented at 12:08 AM on February 5, 2015: member
Tested ACK
- laanwj added the label GUI on Feb 5, 2015
-
ghost commented at 10:48 AM on February 7, 2015: none
First time commenting on a project so I hope I'm doing this correctly and I apologize if this is a stupid question, but is there any effect vis a vis resizing the window with the new image?
-
jonasschnelli commented at 12:10 PM on February 7, 2015: contributor
@L-Cranston-Shadow First github comment. Nice. Thanks for your participation. The resize behavior is still the same. You can still resize the window to a very small size (see below). In the current (0.9.3) and upcoming version 0.10 there is also a image on the about screen which follows the same resize constraints.
Feel free to test it by building bitcoin master yourself of use a prebuilt binary (https://builds.jonasschnelli.ch/pulls/5753/).
- laanwj merged this on Feb 9, 2015
- laanwj closed this on Feb 9, 2015
- laanwj referenced this in commit 0f44672437 on Feb 9, 2015
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels