Rename Interval() to DifficultyAdjustmentInterval() #5799

pull shaulkf wants to merge 1 commits into bitcoin:master from shaulkf:rename-difficulty-adjustment changing 3 files +6 −6

shaulkf commented at 1:59 PM on February 17, 2015: contributor

Rename following discussion in #5739 (comment)
Rename Interval() to DifficultyAdjustmentInterval() e5ece053da
shaulkf commented at 7:07 PM on February 17, 2015: contributor

Tests are passing locally. Does anyone know of a way to locally reproduce the Travis environment?
paveljanik commented at 7:19 PM on February 17, 2015: contributor

read-ACK. The Travis bug seems to be random.
laanwj commented at 10:20 AM on February 18, 2015: member
Very much agree with this, but won't ACK unless it at least passes travis. I'll look into it.

The failure in https://travis-ci.org/bitcoin/bitcoin/jobs/51080203 is triggered by the comparison tool detecting that the node disconnected
```
02:07:41 14 BitcoindComparisonTool$1.onPeerDisconnected: bitcoind node disconnected!
```
The subsequent log however shows that the tool is the one that disconnects, and then a normal shutdown procedure follows.
```
2015-02-17 14:07:42 socket closed
2015-02-17 14:07:42 disconnecting peer=1
2015-02-17 14:07:42 Shutdown: In progress...
```
It's hard to filter out what is happening with the amount of lock-related low-level noise in that log. It may be. It may be that the interesting part of the log precedes that part of the tail that is printed ....
laanwj commented at 11:49 AM on February 18, 2015: member

The travis respin made it pass. There's nothing in this change that could believably introduce intermittent errors, so ACK.
fanquake commented at 12:03 PM on February 18, 2015: member

ACK
laanwj merged this on Feb 18, 2015
laanwj closed this on Feb 18, 2015
laanwj referenced this in commit 8d0418720c on Feb 18, 2015
shaulkf deleted the branch on Mar 17, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

Linked (view graph)

#5739 Replace difficulty readjustment blocks with Interval()