WIN32 Seed Cleanup #5824

pull ghost wants to merge 1 commits into bitcoin:master from changing 1 files +4 −3

ghost commented at 2:10 AM on February 25, 2015: none

WIN32 cleanup of RandAddSeedPerfmon.
gmaxwell commented at 2:13 AM on February 25, 2015: contributor

What is the purpose of this change? The current behavior is intentional.
ghost commented at 2:53 AM on February 25, 2015: none

@gmaxwell Please, do tell. The change introduced here is self-evident, the current intent is less so.
gmaxwell commented at 5:14 AM on February 25, 2015: contributor

I misread the diff and thought you were moving the ifdef WIN32 above the randaddseed(), and thought your goal was to remove all non-urandom sources of entropy from the pool. (which would be unfortunate considering the frequent dev/random failures https://lists.freebsd.org/pipermail/freebsd-current/2015-February/054580.html )

Please provide a commit message..
ghost commented at 5:31 AM on February 25, 2015: none

'WIN32 Seed Cleanup' is the commit message, but certainly not opposed to a more in-depth exposé of your choosing.
paveljanik commented at 6:12 AM on February 25, 2015: contributor

ACK What about: Remember the last time of performance data use on Windows only.
laanwj commented at 9:44 AM on February 25, 2015: member

If you propose a change to the code, the burden of explaining why it is useful is up to you. Something may look 'self-evident' to you but it may not be to others.

That said, ACK after adding a more explanatory commit message.
laanwj added the label Improvement on Feb 25, 2015
gmaxwell commented at 9:49 AM on February 25, 2015: contributor

The message I would have written would be:

"Move nLastPerfmon behind win32 ifdef. Code to avoid calling Perfmon too often is only needed when perfmon is actually going to get called. This is not intended to make any functional difference in the addition of entropy to the random pool."

WIN32 Seed Cleanup: Move nLastPerfmon behind win32 ifdef.

Code to avoid calling Perfmon too often is only needed when perfmon is actually going to get called.
This is not intended to make any functional difference in the addition of entropy to the random pool.

32eaf8a3de

ghost commented at 11:42 PM on February 25, 2015: none

The commit message has now been updated accordingly.
gmaxwell commented at 11:49 PM on February 25, 2015: contributor

utACK. Thanks!
laanwj commented at 8:44 AM on February 26, 2015: member

Thanks, ACK
laanwj merged this on Feb 26, 2015
laanwj closed this on Feb 26, 2015
laanwj referenced this in commit 25d713c941 on Feb 26, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels