qt: Don't save geometry for options and about/help window #5830

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2015_02_qt_geometry changing 2 files +0 −4

laanwj commented at 9:28 AM on February 26, 2015: member

These dialogs will be something that people occasionally open, not keep open during their session, so just popping it up in a sensible place is good enough. Remembering only creates potential issues, like spawning it outside the current screen area.

On Ubuntu this causes the dialogs to be positioned in the middle of the main dialog, so I didn't add code for that. YMMV.

Inspired by github pull #5777 by @L-Cranston-Shadow

qt: Don't save geometry for options and about/help window

These dialogs will be something that people occasionally open, not keep
open during their session, so just popping it up in a sensible place
is good enough. Remembering only creates potential issues, like spawning
it outside the current screen area.

On Ubuntu this causes the dialogs to be positioned in the
middle of the main dialog, so I didn't add code for that. YMMV.

Inspired by github pull #5777 by @L-Cranston-Shadow

6f1274c8c9

Diapolo commented at 10:03 AM on February 26, 2015: none

I'm happy to have that feature for the options window... so NACK from me on that one.
paveljanik commented at 10:19 AM on February 26, 2015: contributor

I think this is good change for both. Remembering the position only makes sense for a window you/user use more often (like e.g. Debug window/Console, Network traffic etc.) and is likely to move it on the screen where he wants to have it.

Options dialog is a different beast IMO.

It would be nice to have a feature to open Debug window at the start automatically and even more nice would be to have the same tab preselected. The user could watch the traffic immediately at the start of the UI...

ACK
ghost commented at 10:22 AM on February 26, 2015: none

@laanwj Apologies for neglecting my pull request and thank you for pickng up the torch on this.

utACK on this for what it's worth, there doesn't seem to me to be enough reason to justify this surplus function.
laanwj commented at 10:23 AM on February 26, 2015: member

@diapolo I just don't see the point. Personally I rather have (run of the mill) sub-windows just pop up relative to their main window instead of wherever I had them last time. The main window itself and the RPC console are exceptions to this as people will want to keep them open at the same time and not overlapping. But for the options window I just don't see the point. @paveljanik Nice idea. Most straightforward would be to remember the visibility of the debug window as well as the position? Seems more intuitive than adding an option.
paveljanik commented at 10:31 AM on February 26, 2015: contributor

wum^H^H^H ;-) @laanwj Even better!
fanquake commented at 12:41 PM on February 26, 2015: member

utACK
laanwj added the label GUI on Feb 27, 2015
jonasschnelli commented at 4:55 AM on March 5, 2015: contributor

Tested ACK. Windows and OSX binaries are here: https://builds.jonasschnelli.ch/pulls/5830/ (Linux build currently fails)
laanwj merged this on Mar 5, 2015
laanwj closed this on Mar 5, 2015
laanwj referenced this in commit 215475aa00 on Mar 5, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#5777 Remove size and position saving in the about window