Fix InvalidateBlock #5879

1. 
   morcos commented at 5:26 PM on March 11, 2015: member

   There was a bug in InvalidateBlock that prevented setBlockIndexCandidates from being properly repopulated. This would prevent you from necessarily ending up on the best chain after calling invalidateblock. I also added an RPC test.

2. 
   gavinandresen commented at 7:03 PM on March 11, 2015: contributor

   Code review ACK.

   Copyright at the top of the new file should have year 2015, if you care about that sort of thing (I don't....)

3. 
   sipa commented at 1:34 PM on March 12, 2015: member

   ACK

4. fix InvalidateBlock to repopulate setBlockIndexCandidates a9af415887
5. add RPC test for InvalidateBlock 88f6c8c365
6. morcos force-pushed on Mar 12, 2015
7. 
   morcos commented at 2:48 PM on March 12, 2015: member

   Rebased to pick up #5883 so hopefully Travis will pass now.

8. laanwj added the label Bug on Mar 12, 2015
9. laanwj added the label RPC on Mar 12, 2015
10. laanwj added this to the milestone 0.10.0 on Mar 12, 2015
11. laanwj merged this on Mar 12, 2015
12. laanwj closed this on Mar 12, 2015

    ---

13. laanwj referenced this in commit 84a7789b29 on Mar 12, 2015
14. laanwj referenced this in commit c91c660e49 on Mar 12, 2015
15. laanwj referenced this in commit 11173786ce on Mar 12, 2015
16. 
    laanwj commented at 4:54 PM on March 12, 2015: member

    cherry-picked to 0.10 via c91c660 1117378

17. reddink referenced this in commit cf1e370244 on Jul 11, 2020
18. reddink referenced this in commit c0325bfc4c on Jul 11, 2020
19. reddink referenced this in commit ab4fd6e828 on Jul 14, 2020
20. reddink referenced this in commit ec34351293 on Jul 14, 2020
21. MarcoFalke locked this on Sep 8, 2021

Milestone
0.10.0