[Refactor] decouple wallet rpc commands #5934

pull jonasschnelli wants to merge 5 commits into bitcoin:master from jonasschnelli:2015/03/wallet_rpc_flex changing 9 files +195 −95

jonasschnelli commented at 9:39 PM on March 21, 2015: contributor

includes #5744
jonasschnelli force-pushed on Mar 21, 2015
jonasschnelli commented at 7:24 PM on March 22, 2015: contributor
I think this PR's implementation is not perfect and is not very modular. But it would give the opportunity to slowly decouple the wallet from the rest of the core. It's unclear why we have a runtime linking of rpc commands and there are probably way better solutions of a dynamic handling of the rpc commands dispatching. But these are out of the PRs focus.

Longterm goals to achieve with this PR:
- Remove/reduce wallet_enabled #ifdefs
- Possibility to switch wallet implementation on compile and/or runtime (as startup/config arg)

in src/rpcclient.h:None in 07c3027982 outdated

   9 | @@ -10,6 +10,16 @@
  10 |  #include "json/json_spirit_utils.h"
  11 |  #include "json/json_spirit_writer_template.h"
  12 |  
  13 | +/**
  14 | + * Add new conversion to the JSON RPC conversion table
  15 | + * @param method name of the method
  16 | + * @param idx    0-based index of the paramter

fanquake commented at 3:36 AM on March 23, 2015:

s/paramter/parameter

laanwj added the label Wallet on Mar 26, 2015
jonasschnelli force-pushed on Apr 12, 2015
jonasschnelli commented at 9:32 AM on April 12, 2015: contributor

Rebased
jtimon commented at 10:37 AM on June 21, 2015: contributor

Needs rebase
jonasschnelli commented at 10:42 AM on June 21, 2015: contributor

@jtimon: will do soon. But maybe this PR #6006 makes more sense. What do you think?

This PR would need a better locking mechanism.

[Modularization] add possibility to extend or overwrite RPC calls

- this will allow a upcomming modularization of the wallet or other components

fb2db9363b

[Modularization] allow to add entries to the JSON conversion table

- add method to insert custom conversion entries

Conflicts:
	src/test/rpc_tests.cpp

326dce820e

[Modularization] flexible RPC table overhaul 0e0f562432

[Modularization] use pointers when adding or replacing RPC commands

Using pointers signals the responsibility of managing object lifetime is in the hand of the caller.

f3fb24e710

[Refactor] decouple wallet rpc commands
includes #5744
a6b659a6b0
jonasschnelli force-pushed on Jun 24, 2015
jonasschnelli commented at 6:46 AM on June 24, 2015: contributor

Rebased. Misses a clever locking for CRPCTable tableRPC. The signaling solution (https://github.com/bitcoin/bitcoin/pull/6006) which supersedes this PR is better IMO.
jonasschnelli commented at 7:12 AM on June 24, 2015: contributor

Closing in favor of #6006
jonasschnelli closed this on Jun 24, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#5744 [Modularization] add possibility to extend or overwrite RPC calls