Remove BIP34 switchover logic #5966

1. 
   laanwj commented at 7:19 am on April 3, 2015: member

   It’s more than a year ago, so just replace the 75%/95% version counting logic with a static historic switchover point.

   Rebase of #5562:

   • Kept IsSuperMajority as it’s used by BIP66 checks
   • Moved nBIP34Height to the new consensus params structure
2. Remove BIP34 switchover logic

   It's more than a year ago, so just replace the 75%/95% version counting
   logic with a static historic switchover point.

   7718158756
3. laanwj added the label Consensus on Apr 3, 2015
4. 
   laanwj commented at 7:49 am on April 3, 2015: member

   Looks like this breaks the pull tester, which relies on BIP34 switch-over logic as it was.
5. 
   jgarzik commented at 5:17 am on April 5, 2015: contributor

   tested ACK
6. 
   laanwj commented at 6:26 am on April 8, 2015: member

   @jgarzik Thanks for testing @TheBlueMatt can you take a look? It looks like we’ll have to change some assumptions in the comparson tool.
7. 
   jtimon commented at 1:49 pm on April 20, 2015: contributor

   Here’s a version rebased on top of #5968 and adding so more consensus params to avoid that ContextualCheckBlockHeader has to have a new couple of lines every time that a softfork gets old enough to enforce it by height rather than voting:

   https://github.com/bitcoin/bitcoin/compare/master...jtimon:bip34_switchover?expand=1

8. 
   luke-jr commented at 2:23 am on June 2, 2015: member

   Minor bug*: If the blockchain were reorganised off the switchover block, we would be breaking consensus here. I wonder if it might be good to abstract #5927 so its logic is reusable for things like this. That is, instead of “when do we enforce BIP34?”, we ask “what blocks are permitted to skip BIP34 validation?”

   * This is only a bug when checkpoints are disabled or #5927 is merged.

9. 
   laanwj commented at 7:48 am on July 3, 2015: member

   Closing this. It has no priority at all. I suppose this could be taken as part of the new bit-based softfork tracking system, at least when the old system is removed.
10. laanwj closed this on Jul 3, 2015

    ---

11. DrahtBot locked this on Sep 8, 2021

Contributors
laanwj jgarzik jtimon luke-jr

Labels
Consensus