It's more than a year ago, so just replace the 75%/95% version counting logic with a static historic switchover point.
Rebase of #5562:
- Kept IsSuperMajority as it's used by BIP66 checks
- Moved nBIP34Height to the new consensus params structure
Remove BIP34 switchover logic #5966
pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2015_04_bip34_switchover changing 3 files +9 −5-
laanwj commented at 7:19 AM on April 3, 2015: member
-
7718158756
Remove BIP34 switchover logic
It's more than a year ago, so just replace the 75%/95% version counting logic with a static historic switchover point.
- laanwj added the label Consensus on Apr 3, 2015
-
laanwj commented at 7:49 AM on April 3, 2015: member
Looks like this breaks the pull tester, which relies on BIP34 switch-over logic as it was.
-
jgarzik commented at 5:17 AM on April 5, 2015: contributor
tested ACK
-
laanwj commented at 6:26 AM on April 8, 2015: member
@jgarzik Thanks for testing @TheBlueMatt can you take a look? It looks like we'll have to change some assumptions in the comparson tool.
-
jtimon commented at 1:49 PM on April 20, 2015: contributor
Here's a version rebased on top of #5968 and adding so more consensus params to avoid that ContextualCheckBlockHeader has to have a new couple of lines every time that a softfork gets old enough to enforce it by height rather than voting:
https://github.com/bitcoin/bitcoin/compare/master...jtimon:bip34_switchover?expand=1
-
luke-jr commented at 2:23 AM on June 2, 2015: member
Minor bug*: If the blockchain were reorganised off the switchover block, we would be breaking consensus here. I wonder if it might be good to abstract #5927 so its logic is reusable for things like this. That is, instead of "when do we enforce BIP34?", we ask "what blocks are permitted to skip BIP34 validation?"
* This is only a bug when checkpoints are disabled or #5927 is merged.
-
laanwj commented at 7:48 AM on July 3, 2015: member
Closing this. It has no priority at all. I suppose this could be taken as part of the new bit-based softfork tracking system, at least when the old system is removed.
- laanwj closed this on Jul 3, 2015
- DrahtBot locked this on Sep 8, 2021
Labels