consensus: don't use arith_uint256 in consensus.h #6000

pull theuni wants to merge 1 commits into bitcoin:master from theuni:5812-no-arith changing 4 files +9 −10

theuni commented at 7:39 PM on April 10, 2015: member

Requiring arith_uint256 at such a base level is not good for modularity. @jtimon: Sorry, this may be a pain in the ass for you as it'll mean adapting some of your other PRs, but since this is already causing indirect issues in #5995, I think it's better to get this in first.

consensus: don't use arith_uint256 in consensus.h

Requiring arith_uint256 at such a base level is not good for modularity.

fd311996e8

jtimon commented at 6:25 AM on April 11, 2015: contributor

ut ACK
sipa commented at 8:23 AM on April 11, 2015: member

utACK
jgarzik commented at 3:28 PM on April 12, 2015: contributor

ut ACK
laanwj commented at 8:40 AM on April 13, 2015: member

#6000 ! utACK

in src/chainparams.cpp:None in fd311996e8

 104 | @@ -105,7 +105,7 @@ class CMainParams : public CChainParams {
 105 |          consensus.nMajorityEnforceBlockUpgrade = 750;
 106 |          consensus.nMajorityRejectBlockOutdated = 950;
 107 |          consensus.nMajorityWindow = 1000;
 108 | -        consensus.powLimit = ~arith_uint256(0) >> 32;
 109 | +        consensus.powLimit = uint256S("00000000ffffffffffffffffffffffffffffffffffffffffffffffffffffffff");

laanwj commented at 9:24 AM on April 13, 2015:

Nice to have these explicit.

laanwj merged this on Apr 13, 2015
laanwj closed this on Apr 13, 2015
laanwj referenced this in commit 9125c08f34 on Apr 13, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

Linked (view graph)

#5995 DEPENDENT: API: Expose bitcoinconsensus_verify_header() in libconsensus