Instead of using an ugly loop hack that swallows break and continue, I have replaced it with a simple if statement.
Please comment and/or apply!
Cleaned up critical section code. #602
pull cgaebel wants to merge 2 commits into bitcoin:master from cgaebel:master changing 2 files +34 −9-
cgaebel commented at 8:35 AM on November 2, 2011: none
-
Cleaned up the critical section macros. 3083cf100a
-
laanwj commented at 9:08 AM on November 2, 2011: member
I like this; it uses the proper c++ idiom (RAII) which is more readable and potentially more robust.
Can you add testcase/unittest?
-
Added simple critical section test cases. f873b84d6e
-
cgaebel commented at 10:11 PM on November 2, 2011: none
Done. Thanks.
-
gavinandresen commented at 10:41 PM on November 9, 2011: contributor
ACK
-
TheBlueMatt commented at 2:14 AM on November 10, 2011: member
It would be nice to test that Critical section code actually works by spawning threads and testing locks in the test suite.
-
gavinandresen commented at 7:32 PM on November 21, 2011: contributor
I'm going to merge this early-- writing multithreaded unit tests would be spiffy, but second-best is to merge early and get lots of testing.
- gavinandresen referenced this in commit 42eb76a054 on Nov 21, 2011
- gavinandresen merged this on Nov 21, 2011
- gavinandresen closed this on Nov 21, 2011
- coblee referenced this in commit 6901f28573 on Jul 17, 2012
- ptschip referenced this in commit 24658df3dd on Aug 19, 2017
- kallewoof referenced this in commit 2c56e0d2b3 on Oct 4, 2019
- rajarshimaitra referenced this in commit 4fb21e5a8c on Aug 5, 2021
- DrahtBot locked this on Sep 8, 2021
Contributors
Labels