Show zero value txouts in listunspent. #6036

pull gmaxwell wants to merge 2 commits into bitcoin:master from gmaxwell:listunspent_zeros changing 4 files +31 −4

gmaxwell commented at 5:17 PM on April 20, 2015: contributor

It's reasonable that automatic coin selection will not pick a zero value txout, but they're actually spendable; and you should know if you have them. Listing also makes them available to tools like dust-b-gone.

Show zero value txouts in listunspent.

It's reasonable that automatic coin selection will not pick a zero
 value txout, but they're actually  spendable; and you should know
 if you have them. Listing also makes them available to tools like
 dust-b-gone.

219953ce50

jgarzik commented at 5:19 PM on April 20, 2015: contributor

ut ACK
sipa commented at 5:26 PM on April 20, 2015: member

Concept ACK.
jonasschnelli commented at 8:28 AM on April 21, 2015: contributor

Tested ACK. Maybe it's worth pulling in this RPC test: https://github.com/jonasschnelli/bitcoin/commit/f23ab0a0f5b111bfd3efcbe77898e03d0e386caf
laanwj commented at 8:52 AM on April 21, 2015: member

utACK, also for @jonasschnelli 's RPC test
add rpc test for listunspents support for zero value txouts f89b092d75
gmaxwell commented at 9:26 AM on April 21, 2015: contributor

@jonasschnelli Thanks!
sipa commented at 11:03 AM on April 21, 2015: member

Code review ACK. Didn't look at the tests.
arnuschky commented at 7:12 PM on April 23, 2015: contributor

Tested it with the wallet that originally raised the issue, results are now as expected and match unspent results of all the other blockchain data providers. Thanks @gmaxwell for the quick patch!

Tests look fine to me, thanks @jonasschnelli
laanwj merged this on Apr 24, 2015
laanwj closed this on Apr 24, 2015
laanwj referenced this in commit 585b5dba74 on Apr 24, 2015
laanwj added the label Wallet on Apr 24, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels