String corrections (mostly grammatical) #6085

pull luke-jr wants to merge 2 commits into bitcoin:master from luke-jr:201504_grammar changing 36 files +111 −109
  1. luke-jr commented at 4:52 PM on April 30, 2015: member

    Mostly just grammar corrections from my wife, but also has a few minor clarifications I noticed when merging her changes in.

    Note: She didn't get to go over everything, but this is better than nothing.

  2. luke-jr force-pushed on Apr 30, 2015
  3. luke-jr force-pushed on May 1, 2015
  4. laanwj added the label Docs and Output on May 1, 2015
  5. Bugfix: Grammar fixes 7e6d23b171
  6. in doc/Doxyfile:None in 9b99d3a4eb outdated
     672 | @@ -673,7 +673,7 @@ FILE_PATTERNS          = *.c \
     673 |                           *.vhd \
     674 |                           *.vhdl
     675 |  
     676 | -# The RECURSIVE tag can be used to turn specify whether or not subdirectories 
     677 | +# The RECURSIVE tag can in turn be used to specify whether or not subdirectories
    


    fanquake commented at 6:04 AM on May 1, 2015:

    We shouldn't really be modifying docs in here. It'll be fixed when we update the Doxyfile itself.


    luke-jr commented at 11:22 AM on May 1, 2015:

    Ok, removed

  7. luke-jr force-pushed on May 1, 2015
  8. in src/bitcoin-cli-res.rc:None in 9a6bd95274 outdated
      23 |              VALUE "InternalName",       "bitcoin-cli"
      24 |              VALUE "LegalCopyright",     COPYRIGHT_STR
      25 |              VALUE "LegalTrademarks1",   "Distributed under the MIT software license, see the accompanying file COPYING or http://www.opensource.org/licenses/mit-license.php."
      26 |              VALUE "OriginalFilename",   "bitcoin-cli.exe"
      27 | -            VALUE "ProductName",        "Bitcoin-cli"
      28 | +            VALUE "ProductName",        "bitcoin-cli"
    


    laanwj commented at 3:41 PM on May 1, 2015:

    What is the effect of a ProductName change? (what is this used for?)


    laanwj commented at 6:37 PM on May 1, 2015:

    Also: you're not making the same first letter decapitalization change in src/bitcoind-res.rc and src/qt/rec/bitcoin-qt-res.rc

  9. laanwj commented at 6:33 PM on May 1, 2015: member

    ACK (apart from .rc nit)

  10. Non-grammatical language improvements b05a89b2de
  11. luke-jr force-pushed on May 2, 2015
  12. luke-jr commented at 3:24 PM on May 2, 2015: member

    Reverted the .rc changes, it can go in independently if desired.

  13. jgarzik commented at 4:04 PM on May 2, 2015: contributor

    ACK

  14. laanwj merged this on May 4, 2015
  15. laanwj closed this on May 4, 2015

  16. laanwj referenced this in commit 00e76db8c2 on May 4, 2015
  17. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me