Update Windows resource files (and add one for bitcoin-tx) #6098

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:201505_win_rc changing 5 files +44 −5

luke-jr commented at 3:31 PM on May 2, 2015: member

I have not tested this at all.
jgarzik commented at 3:56 PM on May 2, 2015: contributor

ut ACK
luke-jr force-pushed on May 2, 2015
luke-jr force-pushed on May 3, 2015
luke-jr force-pushed on May 3, 2015
laanwj added the label Windows on May 4, 2015
laanwj added the label Build system on May 4, 2015
laanwj commented at 3:07 PM on May 6, 2015: member

@theuni This changes the build system to add a windows resource file, can you take a look if it's correct?
theuni commented at 5:32 PM on May 6, 2015: member

Looks good to me. Travis builds and inserts these, so we can be somewhat confident that they're working as intended. utACK.
in src/bitcoind-res.rc:None in 6a3dd529bc outdated
```
  16 | @@ -17,13 +17,13 @@ BEGIN
  17 |          BLOCK "040904E4" // U.S. English - multilingual (hex)
  18 |          BEGIN
  19 |              VALUE "CompanyName",        "Bitcoin"
  20 | -            VALUE "FileDescription",    "Bitcoind (OSS daemon/client for Bitcoin)"
  21 | +            VALUE "FileDescription",    "bitcoind (Bitcoin client as a JSON-RPC server)"
```
sipa commented at 3:18 AM on May 8, 2015:

JSON-RPC is hardly the only thing it does. I would just say headless version or version without GUI.

luke-jr commented at 5:02 AM on May 8, 2015:

It's the only user interface... "headless" or "without GUI" implies it is suitable for human use.

sipa commented at 5:36 AM on May 8, 2015:

But a Bitcoin node is useful even if you don't use its RPC functionality, for example by connecting a lightweight client using P2P to it.

Bitcoind is bitcoin-qt without the GUI part, so it's a headless version - regardless of how you use it.

jgarzik commented at 9:35 AM on May 8, 2015:

+1 @sipa

laanwj commented at 12:22 PM on May 12, 2015:

I like "headless Bitcoin node". "Client" is also the wrong word to use in a P2P world.

luke-jr commented at 5:28 PM on May 12, 2015:

So... "bitcoind (Bitcoin node with a JSON-RPC server)"?

laanwj commented at 8:44 AM on May 16, 2015:

Fine with me.

in src/bitcoin-cli-res.rc:None in 6a3dd529bc outdated

  16 | @@ -17,13 +17,13 @@ BEGIN
  17 |          BLOCK "040904E4" // U.S. English - multilingual (hex)
  18 |          BEGIN
  19 |              VALUE "CompanyName",        "Bitcoin"
  20 | -            VALUE "FileDescription",    "Bitcoin-cli (OSS RPC client for Bitcoin)"
  21 | +            VALUE "FileDescription",    "bitcoin-cli (JSON-RPC client for Bitcoin Core)"

Diapolo commented at 8:45 AM on May 11, 2015:

So it is not Open source anymore?

laanwj commented at 11:22 AM on May 11, 2015:

I'm not sure license information belongs in the simple file description (and OSS is not a very common abbreviation in any case. And "Open source", at that, is very general, almost void of meaning)

laanwj commented at 11:46 AM on May 20, 2015: member

@luke-jr are you planning to update the name so that this can be merged?
luke-jr force-pushed on May 20, 2015
luke-jr commented at 6:02 PM on May 20, 2015: member

@laanwj Woops, thought I already had, sorry. Done.
Update Windows resource files (and add one for bitcoin-tx) cc24610fdb

in src/qt/res/bitcoin-qt-res.rc:None in 9b6e411c65 outdated

  18 | @@ -19,7 +19,7 @@ BEGIN
  19 |          BLOCK "040904E4" // U.S. English - multilingual (hex)
  20 |          BEGIN
  21 |              VALUE "CompanyName",        "Bitcoin"
  22 | -            VALUE "FileDescription",    "Bitcoin Core (OSS GUI client for Bitcoin)"
  23 | +            VALUE "FileDescription",    "Bitcoin Core (GUI client for Bitcoin)"

laanwj commented at 10:00 AM on May 21, 2015:

Ugh, we have to client->node here to, to be consistent with the bitcoind change ("GUI Bitcoin node"?)

luke-jr commented at 2:57 AM on May 22, 2015:

Fixed

luke-jr force-pushed on May 22, 2015
laanwj merged this on May 22, 2015
laanwj closed this on May 22, 2015
laanwj referenced this in commit 7708fcde36 on May 22, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels